Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(1)

Issue 1165223006: Move WebVR public headers into public/platform/modules/vr (Closed)

Created:
4 years, 10 months ago by bajones
Modified:
4 years, 10 months ago
CC:
blink-reviews, dglazkov+blink
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Move WebVR public headers into public/platform/modules/vr Since no Chrome code depends on these files yet (till https://codereview.chromium.org/829803003/ lands) this is an easy move to make now. Also updated WebVRDevice to use WebString instead of WebUChar[]. The previous code was aimed at sending WebVRDevice's over Chrome's IPC channels. The latest WebVR code uses mojo for IPC, and as such it's easier and safer to use WebString here instead. BUG=453032 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=196885

Patch Set 1 #

Patch Set 2 : Moved public headers to public/platform/modules/vr #

Total comments: 1

Patch Set 3 : Fixed mismatched forward declaration #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -167 lines) Patch
M Source/modules/vr/HMDVRDevice.h View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/vr/VRController.h View 1 1 chunk +2 lines, -2 lines 0 comments Download
M Source/modules/vr/VREyeParameters.h View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/vr/VRFieldOfView.h View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/vr/VRGetDevicesCallback.h View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/vr/VRHardwareUnitCollection.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/vr/VRPositionState.h View 1 1 chunk +1 line, -1 line 0 comments Download
M public/platform/WebVR.h View 1 1 chunk +0 lines, -113 lines 0 comments Download
D public/platform/WebVRClient.h View 1 1 chunk +0 lines, -31 lines 0 comments Download
A + public/platform/modules/vr/OWNERS View 1 1 chunk +0 lines, -1 line 0 comments Download
A + public/platform/modules/vr/WebVR.h View 1 2 chunks +4 lines, -13 lines 0 comments Download
A + public/platform/modules/vr/WebVRClient.h View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (5 generated)
bajones
While making a small update to WebVR.h I noticed that multiple other modules public headers ...
4 years, 10 months ago (2015-06-09 23:21:37 UTC) #2
Mike West
LGTM. https://codereview.chromium.org/1165223006/diff/20001/public/platform/modules/vr/OWNERS File public/platform/modules/vr/OWNERS (right): https://codereview.chromium.org/1165223006/diff/20001/public/platform/modules/vr/OWNERS#newcode1 public/platform/modules/vr/OWNERS:1: bajones@chromium.org I'd suggest finding a partner so you're ...
4 years, 10 months ago (2015-06-10 07:38:58 UTC) #3
jochen (gone - plz use gerrit)
lgtm
4 years, 10 months ago (2015-06-10 08:34:58 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1165223006/20001
4 years, 10 months ago (2015-06-10 16:19:00 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: mac_blink_rel on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/mac_blink_rel/builds/58406)
4 years, 10 months ago (2015-06-10 16:29:38 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1165223006/40001
4 years, 10 months ago (2015-06-10 16:55:47 UTC) #11
commit-bot: I haz the power
4 years, 10 months ago (2015-06-10 18:03:31 UTC) #12
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=196885

Powered by Google App Engine
This is Rietveld 408576698