Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(96)

Side by Side Diff: public/web/WebPlugin.h

Issue 1165103004: printPage to return void instead of bool (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Rebaseline fixes Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « Source/web/tests/WebPluginContainerTest.cpp ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2009, 2012 Google Inc. All rights reserved. 2 * Copyright (C) 2009, 2012 Google Inc. All rights reserved.
3 * Copyright (C) 2014 Opera Software ASA. All rights reserved. 3 * Copyright (C) 2014 Opera Software ASA. All rights reserved.
4 * 4 *
5 * Redistribution and use in source and binary forms, with or without 5 * Redistribution and use in source and binary forms, with or without
6 * modification, are permitted provided that the following conditions are 6 * modification, are permitted provided that the following conditions are
7 * met: 7 * met:
8 * 8 *
9 * * Redistributions of source code must retain the above copyright 9 * * Redistributions of source code must retain the above copyright
10 * notice, this list of conditions and the following disclaimer. 10 * notice, this list of conditions and the following disclaimer.
(...skipping 115 matching lines...) Expand 10 before | Expand all | Expand 10 after
126 virtual bool isPrintScalingDisabled() { return false; } 126 virtual bool isPrintScalingDisabled() { return false; }
127 // Returns true on success and sets the out parameter to the print preset op tions for the document. 127 // Returns true on success and sets the out parameter to the print preset op tions for the document.
128 virtual bool getPrintPresetOptionsFromDocument(WebPrintPresetOptions*) { ret urn false; } 128 virtual bool getPrintPresetOptionsFromDocument(WebPrintPresetOptions*) { ret urn false; }
129 129
130 // Sets up printing with the specified printParams. Returns the number of 130 // Sets up printing with the specified printParams. Returns the number of
131 // pages to be printed at these settings. 131 // pages to be printed at these settings.
132 virtual int printBegin(const WebPrintParams& printParams) { return 0; } 132 virtual int printBegin(const WebPrintParams& printParams) { return 0; }
133 133
134 // Prints the page specified by pageNumber (0-based index) into the supplied canvas. 134 // Prints the page specified by pageNumber (0-based index) into the supplied canvas.
135 virtual bool printPage(int pageNumber, WebCanvas* canvas) { return false; } 135 virtual bool printPage(int pageNumber, WebCanvas* canvas) { return false; }
136 // TODO: Remove third parameter when both blink and chromium changes land fo r bug496765
137 virtual void printPage(int pageNumber, WebCanvas* canvas, bool unused) { }
138
136 // Ends the print operation. 139 // Ends the print operation.
137 virtual void printEnd() { } 140 virtual void printEnd() { }
138 141
139 virtual bool hasSelection() const { return false; } 142 virtual bool hasSelection() const { return false; }
140 virtual WebString selectionAsText() const { return WebString(); } 143 virtual WebString selectionAsText() const { return WebString(); }
141 virtual WebString selectionAsMarkup() const { return WebString(); } 144 virtual WebString selectionAsMarkup() const { return WebString(); }
142 145
143 virtual bool executeEditCommand(const WebString& name) { return false; } 146 virtual bool executeEditCommand(const WebString& name) { return false; }
144 virtual bool executeEditCommand(const WebString& name, const WebString& valu e) { return false; } 147 virtual bool executeEditCommand(const WebString& name, const WebString& valu e) { return false; }
145 148
(...skipping 37 matching lines...) Expand 10 before | Expand all | Expand 10 after
183 virtual bool isPlaceholder() { return true; } 186 virtual bool isPlaceholder() { return true; }
184 virtual bool shouldPersist() const { return false; } 187 virtual bool shouldPersist() const { return false; }
185 188
186 protected: 189 protected:
187 ~WebPlugin() { } 190 ~WebPlugin() { }
188 }; 191 };
189 192
190 } // namespace blink 193 } // namespace blink
191 194
192 #endif 195 #endif
OLDNEW
« no previous file with comments | « Source/web/tests/WebPluginContainerTest.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698