Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(535)

Issue 1165103003: [turbofan] Add mjsunit tests for try-catch-finally and OSR. (Closed)

Created:
5 years, 6 months ago by Michael Starzinger
Modified:
5 years, 6 months ago
Reviewers:
titzer
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@local_trycatch-flag
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Add mjsunit tests for try-catch-finally and OSR. This adds some basic tests of the interaction between try-catch and try-finally statements and OSR in TurboFan. The try-osr test suite follows the structure of try-deopt closely. R=titzer@chromium.org TEST=mjsunit/compiler/try-osr Committed: https://crrev.com/74c730a08d3832571d57bed76d974a0fa793dfff Cr-Commit-Position: refs/heads/master@{#28855}

Patch Set 1 #

Patch Set 2 : Tiny cleanup. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+51 lines, -4 lines) Patch
M test/cctest/compiler/test-run-jsexceptions.cc View 1 chunk +0 lines, -4 lines 0 comments Download
A test/mjsunit/compiler/try-osr.js View 1 1 chunk +51 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
Michael Starzinger
5 years, 6 months ago (2015-06-08 16:48:04 UTC) #1
titzer
lgtm
5 years, 6 months ago (2015-06-08 17:00:57 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1165103003/1
5 years, 6 months ago (2015-06-09 07:50:22 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1165103003/20001
5 years, 6 months ago (2015-06-09 07:53:24 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 6 months ago (2015-06-09 08:16:38 UTC) #9
commit-bot: I haz the power
5 years, 6 months ago (2015-06-09 08:16:54 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/74c730a08d3832571d57bed76d974a0fa793dfff
Cr-Commit-Position: refs/heads/master@{#28855}

Powered by Google App Engine
This is Rietveld 408576698