Merge page serializers [1/12]

Move image error test

Move WebPageNewSerializerTest.ImageError test to PageSerializerTest.

--

This review is part of set aiming to merge the two existing page
serializers, WebPageSerializerImpl and PageSerializer into the latter
one.

In addition to this it moves all the old tests from
WebPageNewSerializerTest and WebPageSerializerTest to the newer
PageSerializerTest structure and splits out a test for MHTML into the
MHTMLTest file.

Note: This is a rebase and split of
https://codereview.chromium.org/68613003 from Opera which was reverted
due to failing tests. In addition to the rebase some smaller fixes was
done to accommodate to changes in the code from when it was first
landed.

BUG=328354
R=philipj@opera.com

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=196659

[Tiger (Sony Mobile), 2015-06-05 11:21:32]

gustav.tiger@sonymobile.com changed reviewers:
+ jochen@chromium.org

[philipj_slow, 2015-06-05 11:32:50]

philipj@opera.com changed reviewers:
+ hajimehoshi@chromium.org

[philipj_slow, 2015-06-05 11:32:50]

hajimehoshi@, this is a long series of fixes to the page serializer code. I
can't find an obvious owner for this code, but you've poked at it a bit? Is this
patch series something you're interested in reviewing?

[philipj_slow, 2015-06-05 11:59:16]

LGTM with nits, but please wait to see if hajimehoshi@ is interested in
reviewing these CLs.

https://codereview.chromium.org/1165093002/diff/1/Source/web/tests/PageSerial...
File Source/web/tests/PageSerializerTest.cpp (right):

https://codereview.chromium.org/1165093002/diff/1/Source/web/tests/PageSerial...
Source/web/tests/PageSerializerTest.cpp:143: void printResources()
I don't know, I'd probably leave this out. If you do want it, #ifndef NDEBUG and
calling it showResources() would make it more in line with things like
DocumentMarkerController::showMarkers() and Node::showNode().

[Tiger (Sony Mobile), 2015-06-05 13:47:50]

https://codereview.chromium.org/1165093002/diff/1/Source/web/tests/PageSerial...
File Source/web/tests/PageSerializerTest.cpp (right):

https://codereview.chromium.org/1165093002/diff/1/Source/web/tests/PageSerial...
Source/web/tests/PageSerializerTest.cpp:143: void printResources()
On 2015/06/05 11:59:16, philipj wrote:
> I don't know, I'd probably leave this out. If you do want it, #ifndef NDEBUG
and
> calling it showResources() would make it more in line with things like
> DocumentMarkerController::showMarkers() and Node::showNode().

Agreed, it is not that important.

[Tiger (Sony Mobile), 2015-06-05 23:51:50]

I'll adjust the total number of patches a bit, it'll be a bit lower, so please
don't put on CQ yet.

[Tiger (Sony Mobile), 2015-06-06 01:26:28]

On 2015/06/05 23:51:50, Tiger (Sony Mobile) wrote:
> I'll adjust the total number of patches a bit, it'll be a bit lower, so please
> don't put on CQ yet.

Done

[philipj_slow, 2015-06-06 06:28:24]

On 2015/06/06 01:26:28, Tiger (Sony Mobile) wrote:
> On 2015/06/05 23:51:50, Tiger (Sony Mobile) wrote:
> > I'll adjust the total number of patches a bit, it'll be a bit lower, so
please
> > don't put on CQ yet.
> 
> Done

It's quite likely that the number will change as we go, so I think it's more
useful to just use "Move WebPageNewSerializerTest.ImageError test to
PageSerializerTest" as the title, the tracking bug will tie them all together.

[hajimehoshi, 2015-06-08 04:07:06]

> hajimehoshi@, this is a long series of fixes to the page serializer code. I
> can't find an obvious owner for this code, but you've poked at it a bit? Is
this
> patch series something you're interested in reviewing?

Yes, I'm working on StyledMarkupAccumulator/Serializer, which has become
independent of MarkupAccumulator. I don't plan to work on PageSerializer, but
I'm interested in this.

This CL sgtm BTW.

[Tiger (Sony Mobile), 2015-06-08 08:15:57]

The CQ bit was checked by gustav.tiger@sonymobile.com

[Tiger (Sony Mobile), 2015-06-08 08:15:57]

The patchset sent to the CQ was uploaded after l-g-t-m from philipj@opera.com
Link to the patchset: https://codereview.chromium.org/1165093002/#ps40001
(title: " ")

[commit-bot: I haz the power, 2015-06-08 08:16:20]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1165093002/40001

[commit-bot: I haz the power, 2015-06-08 09:17:53]

Committed patchset #3 (id:40001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=196659