Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(292)

Unified Diff: device/bluetooth/bluetooth_adapter.h

Issue 1165053003: Adding support for Low Energy device discovery to BluetoothAdapterMac (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: adding issue # Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: device/bluetooth/bluetooth_adapter.h
diff --git a/device/bluetooth/bluetooth_adapter.h b/device/bluetooth/bluetooth_adapter.h
index 7c87eb835018f15fea211b56417618f81569f2a3..30e775af802db69566c45d7ee79f42418b908b99 100644
--- a/device/bluetooth/bluetooth_adapter.h
+++ b/device/bluetooth/bluetooth_adapter.h
@@ -422,7 +422,9 @@ class DEVICE_BLUETOOTH_EXPORT BluetoothAdapter
// success.
//
// |discovery_filter| passed to AddDiscoverySession and RemoveDiscoverySession
- // is owned by other objects and shall not be freed.
+ // is owned by other objects and shall not be freed. When the count is
+ // greater than 0 and AddDiscoverySession (RemoveDiscoverySession) is called
armansito 2015/06/09 19:32:58 I'm confused by the parentheses? Do you mean "AddD
krstnmnlsn 2015/06/09 23:09:00 Yep, switched.
+ // the filter being used by the underlying controller must be updated.
//
// These methods invoke |callback| for success and |error_callback| for
// failures.
@@ -433,6 +435,8 @@ class DEVICE_BLUETOOTH_EXPORT BluetoothAdapter
BluetoothDiscoveryFilter* discovery_filter,
const base::Closure& callback,
const ErrorCallback& error_callback) = 0;
armansito 2015/06/09 19:32:59 nit: New line before the comment block (keeps thin
krstnmnlsn 2015/06/09 23:09:01 Done.
+ // Used to set and update the discovery filter used by the underlying
+ // bluetooth controller.
armansito 2015/06/09 19:32:59 nit: s/bluetooth/Bluetooth/
krstnmnlsn 2015/06/09 23:09:00 Done.
virtual void SetDiscoveryFilter(
scoped_ptr<BluetoothDiscoveryFilter> discovery_filter,
const base::Closure& callback,

Powered by Google App Engine
This is Rietveld 408576698