Deprecate the allowfullscreen exemption for <video>

Deprecate the allowfullscreen exemption for <video>

BUG=496637
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=196797

[philipj_slow, 2015-06-04 12:22:58]

philipj@opera.com changed reviewers:
+ falken@chromium.org

[philipj_slow, 2015-06-04 12:22:59]

PTAL. Depends on https://codereview.chromium.org/1159593006/

I won't land this until I have some feedback on blink-dev.

[falken, 2015-06-08 03:22:29]

lgtm if blink-dev feedback is positive.

https://codereview.chromium.org/1165013002/diff/1/Source/core/frame/UseCounte...
File Source/core/frame/UseCounter.cpp (right):

https://codereview.chromium.org/1165013002/diff/1/Source/core/frame/UseCounte...
Source/core/frame/UseCounter.cpp:921: return "Entering fullscreen in an <iframe>
with no allowfullscreen attribute is deprecated and will stop working in M46,
around October 2015. Please use the allowfullscreen attribute.";
Hum, I don't know whether Blink should refer to Chrome milestones, since there
can be other embedders. But I see other strings here do it too.

[philipj_slow, 2015-06-09 19:17:17]

https://codereview.chromium.org/1165013002/diff/1/Source/core/frame/UseCounte...
File Source/core/frame/UseCounter.cpp (right):

https://codereview.chromium.org/1165013002/diff/1/Source/core/frame/UseCounte...
Source/core/frame/UseCounter.cpp:921: return "Entering fullscreen in an <iframe>
with no allowfullscreen attribute is deprecated and will stop working in M46,
around October 2015. Please use the allowfullscreen attribute.";
On 2015/06/08 03:22:29, falken wrote:
> Hum, I don't know whether Blink should refer to Chrome milestones, since there
> can be other embedders. But I see other strings here do it too.

Yeah, this looks a bit odd, but Chromium is the only Blink embedder and there's
no other human-understandable version number we could really use here.

[philipj_slow, 2015-06-09 19:18:34]

No feedback from anyone but you on blink-dev, so I'll take the silence as
support, since we already had support to do the removal once.

[philipj_slow, 2015-06-09 19:27:07]

The CQ bit was checked by philipj@opera.com

[philipj_slow, 2015-06-09 19:27:08]

The patchset sent to the CQ was uploaded after l-g-t-m from falken@chromium.org
Link to the patchset: https://codereview.chromium.org/1165013002/#ps20001
(title: "rebase")

[commit-bot: I haz the power, 2015-06-09 19:27:18]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1165013002/20001

[commit-bot: I haz the power, 2015-06-09 20:30:13]

Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=196797