Issue 1165003006: Various fixes in preparation for deploying

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1165003006: Various fixes in preparation for deploying (Closed)

Created:
5 years, 6 months ago by eseidel

Modified:
5 years, 6 months ago

Reviewers:
abarth-chromium

CC:
abarth-chromium, Aaron Boodman, ben+mojo_chromium.org, darin (slow to review), gregsimon, jackson_old, mojo-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org

Base URL:
git@github.com:domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

More Reviews

Description

Various fixes in preparation for deploying Fixed the mojo deploy script to no longer deploy mojo. mojo now uses a more sophisticated CDN, etc. Fixed old fn.dart to work again. :) Looks like it was victim of a mass rename. Fixed engine.cc to be able to handle navigating from WebView content to SkyView content. We can't handle the other direction yet, but we don't need to. /sky_home is written in the .sky system but all of our new examples are .dart (and thus SkyView). R=abarth@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/dd0b17ea388e1db6eef9c33b54959d0c938b5068

Patch Set 1 #

Patch Set 2 : Remove game changes #

Total comments: 1

Created: 5 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+21 lines, -19 lines)			Patch
M	mojo/tools/deploy_domokit_site.py	View	1 chunk	+0 lines, -9 lines	0 comments	Download
M	sky/sdk/lib/framework/fn.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	sky/sdk/lib/framework/layout.dart	View	2 chunks	+3 lines, -3 lines	0 comments	Download
M	sky/shell/ui/engine.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	sky/shell/ui/engine.cc	View	2 chunks	+16 lines, -6 lines	1 comment	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

abarth-chromium

lgtm https://codereview.chromium.org/1165003006/diff/10007/sky/shell/ui/engine.cc File sky/shell/ui/engine.cc (right): https://codereview.chromium.org/1165003006/diff/10007/sky/shell/ui/engine.cc#newcode138 sky/shell/ui/engine.cc:138: { These two lines should be merged.

5 years, 6 months ago (2015-06-04 23:46:43 UTC) #2

eseidel

5 years, 6 months ago (2015-06-04 23:48:14 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 (id:10007) manually as
dd0b17ea388e1db6eef9c33b54959d0c938b5068 (presubmit successful).

Expand Messages | Collapse Messages