Issue 1165003005: [es6] Array.prototype.find and findIndex should include holes

Issue 1165003005: [es6] Array.prototype.find and findIndex should include holes (Closed)

Created:
5 years, 6 months ago by arv (Not doing code reviews)

Modified:
5 years, 6 months ago

Reviewers:
adamk

CC:
v8-dev

Base URL:
https://chromium.googlesource.com/v8/v8.git@master

Target Ref:
refs/pending/heads/master

Project:
v8

Visibility:
Public.

[es6] Array.prototype.find and findIndex should include holes We should not skip holes for these 2 functions. BUG=v8:3895 LOG=N R=adamk Committed: https://crrev.com/d269e22de93efa6abc45c386939fdec44ffe9fdf Cr-Commit-Position: refs/heads/master@{#28814}

Created: 5 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+58 lines, -18 lines)			Patch
M	src/harmony-array.js	View		2 chunks	+8 lines, -12 lines	0 comments	Download
M	test/mjsunit/harmony/array-find.js	View		2 chunks	+22 lines, -2 lines	0 comments	Download
M	test/mjsunit/harmony/array-findindex.js	View		2 chunks	+22 lines, -2 lines	0 comments	Download
M	test/test262-es6/test262-es6.status	View	1 2	2 chunks	+6 lines, -2 lines	0 comments	Download

Total messages: 8 (2 generated)

adamk

You'll need to remove the "skip-empty" line from test262-es6.status to pass the CQ. lgtm with ...

5 years, 6 months ago (2015-06-04 22:55:44 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1165003005/40001

5 years, 6 months ago (2015-06-05 13:56:00 UTC) #6

commit-bot: I haz the power

5 years, 6 months ago (2015-06-05 14:18:32 UTC) #8

Message was sent while issue was closed.

Patchset 3 (id:??) landed as
https://crrev.com/d269e22de93efa6abc45c386939fdec44ffe9fdf
Cr-Commit-Position: refs/heads/master@{#28814}