[iOS] Add a repack steps to iOS upstream for unit tests

[iOS] Add a repack steps to iOS upstream for unit tests

//ios unit tests will soon required access to packed resources (both theme
and strings) so add steps required to repack data.

Those steps only pack what is required by //ios unit tests and thus pack to
repack_ios to avoid collision with downstream packing steps. Eventually the
upstream and downstream repack steps will be merged.

This forks some steps from //chrome since //ios cannot depends on //chrome
and those steps are too specific to Chrome to be moved higher in //build.

BUG=429756, 475514
Committed: https://crrev.com/6248cdd125afa37ac0f81f5bfda9219d153fcf1e
Cr-Commit-Position: refs/heads/master@{#333229}

[sdefresne, 2015-06-05 08:59:16]

sdefresne@chromium.org changed reviewers:
+ droger@chromium.org

[sdefresne, 2015-06-05 08:59:17]

droger: can you do a first pass before I send it to OWNERS (stuartmorgan and
dpranke).

[droger, 2015-06-05 09:18:37]

Some high level questions to better understand:

What are the implications for our downstream build (what will we use downstream
from this, what will we need to change)?

Can we remove iOS specific code from the other repack_locale file, or is it
still used downstream?

https://codereview.chromium.org/1164983004/diff/1/ios/chrome/ios_chrome_resou...
File ios/chrome/ios_chrome_resources.gyp (right):

https://codereview.chromium.org/1164983004/diff/1/ios/chrome/ios_chrome_resou...
ios/chrome/ios_chrome_resources.gyp:96: 'grit_whitelist': '',
Does this wort downstream too or will we still need to keep the whitelist
downstream?

[sdefresne, 2015-06-05 09:56:16]

On 2015/06/05 09:18:37, droger wrote:
> Some high level questions to better understand:
> 
> What are the implications for our downstream build (what will we use
downstream
> from this, what will we need to change)?

No impact downstream, the new target generates files in a separate directory
"<(SHARED_INTERMEDIATE_DIR)/repack_ios" and only the targets that do "includes"
of ios/chrome/ios_chrome_bundle_resources.gypi will depends and bundle those
resources (currently only ios_chrome_unittests).

Downstream will continue using the old way to pack files. My goal here is to
avoid introducing regression downstream.

> Can we remove iOS specific code from the other repack_locale file, or is it
> still used downstream?

Nope, they are still used by the old process. I'll try to merge the process so
that downstream uses those packed resources and repack them again in a followup
downstream CL. For the moment the two packing steps are completely independent
(per design).

>
https://codereview.chromium.org/1164983004/diff/1/ios/chrome/ios_chrome_resou...
> File ios/chrome/ios_chrome_resources.gyp (right):
> 
>
https://codereview.chromium.org/1164983004/diff/1/ios/chrome/ios_chrome_resou...
> ios/chrome/ios_chrome_resources.gyp:96: 'grit_whitelist': '',
> Does this wort downstream too or will we still need to keep the whitelist
> downstream?

This will work downstream too.

[droger, 2015-06-05 11:04:00]

lgtm

https://codereview.chromium.org/1164983004/diff/1/ios/chrome/ios_chrome_repac...
File ios/chrome/ios_chrome_repack_locales.gypi (right):

https://codereview.chromium.org/1164983004/diff/1/ios/chrome/ios_chrome_repac...
ios/chrome/ios_chrome_repack_locales.gypi:1: # Copyright (c) 2012 The Chromium
Authors. All rights reserved.
s/(c) 2012/2015/

https://codereview.chromium.org/1164983004/diff/1/ios/chrome/ios_chrome_resou...
File ios/chrome/ios_chrome_resources.gyp (right):

https://codereview.chromium.org/1164983004/diff/1/ios/chrome/ios_chrome_resou...
ios/chrome/ios_chrome_resources.gyp:31: 'includes':
['ios_chrome_repack_100_percent.gypi'],
Maybe inline this, since it's used in only one place.

https://codereview.chromium.org/1164983004/diff/1/ios/chrome/tools/build/ios_...
File ios/chrome/tools/build/ios_repack_locales.py (right):

https://codereview.chromium.org/1164983004/diff/1/ios/chrome/tools/build/ios_...
ios/chrome/tools/build/ios_repack_locales.py:2: # Copyright (c) 2012 The
Chromium Authors. All rights reserved.
s/(c) 2012/2015/

[sdefresne, 2015-06-05 11:41:00]

sdefresne@chromium.org changed reviewers:
+ dpranke@chromium.org

[sdefresne, 2015-06-05 11:41:01]

dpranke: review of //build as OWNERS

https://codereview.chromium.org/1164983004/diff/1/ios/chrome/ios_chrome_repac...
File ios/chrome/ios_chrome_repack_locales.gypi (right):

https://codereview.chromium.org/1164983004/diff/1/ios/chrome/ios_chrome_repac...
ios/chrome/ios_chrome_repack_locales.gypi:1: # Copyright (c) 2012 The Chromium
Authors. All rights reserved.
On 2015/06/05 11:04:00, droger wrote:
> s/(c) 2012/2015/

Inlined the files.

https://codereview.chromium.org/1164983004/diff/1/ios/chrome/ios_chrome_resou...
File ios/chrome/ios_chrome_resources.gyp (right):

https://codereview.chromium.org/1164983004/diff/1/ios/chrome/ios_chrome_resou...
ios/chrome/ios_chrome_resources.gyp:31: 'includes':
['ios_chrome_repack_100_percent.gypi'],
On 2015/06/05 11:04:00, droger wrote:
> Maybe inline this, since it's used in only one place.

Done.

https://codereview.chromium.org/1164983004/diff/1/ios/chrome/ios_chrome_resou...
ios/chrome/ios_chrome_resources.gyp:96: 'grit_whitelist': '',
On 2015/06/05 09:18:37, droger wrote:
> Does this wort downstream too or will we still need to keep the whitelist
> downstream?

As discussed offline, this is no longer required as the bug has been fixed.

https://codereview.chromium.org/1164983004/diff/1/ios/chrome/tools/build/ios_...
File ios/chrome/tools/build/ios_repack_locales.py (right):

https://codereview.chromium.org/1164983004/diff/1/ios/chrome/tools/build/ios_...
ios/chrome/tools/build/ios_repack_locales.py:2: # Copyright (c) 2012 The
Chromium Authors. All rights reserved.
On 2015/06/05 11:04:00, droger wrote:
> s/(c) 2012/2015/

Done.

[Dirk Pranke, 2015-06-05 18:04:01]

lgtm

[sdefresne, 2015-06-07 07:51:36]

The CQ bit was checked by sdefresne@chromium.org

[sdefresne, 2015-06-07 07:51:37]

The patchset sent to the CQ was uploaded after l-g-t-m from droger@chromium.org
Link to the patchset: https://codereview.chromium.org/1164983004/#ps20001
(title: "Address comments and inline .gypi that were used only once")

[commit-bot: I haz the power, 2015-06-07 07:51:45]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1164983004/20001

[commit-bot: I haz the power, 2015-06-07 08:58:14]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-06-07 08:59:12]

Patchset 2 (id:??) landed as
https://crrev.com/6248cdd125afa37ac0f81f5bfda9219d153fcf1e
Cr-Commit-Position: refs/heads/master@{#333229}