Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Issue 1164983003: AudioPlayer.app: Use HTML Imports to define custom elements. (Closed)

Created:
5 years, 6 months ago by fukino
Modified:
5 years, 6 months ago
Reviewers:
yoshiki
CC:
chromium-reviews, rginda+watch_chromium.org, mtomasz+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

AudioPlayer.app: Use HTML Imports to define custom elements. In Polymer 1.0, defining custom elements in the main HTML document is not currently supported. This CL is for preparing upgrade to 1.0. BUG=492939 TEST=manually Committed: https://crrev.com/9123eef92f22dd054fae62234d513916f3e54d49 Cr-Commit-Position: refs/heads/master@{#333236}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+205 lines, -172 lines) Patch
M tools/gritsettings/resource_ids View 1 chunk +1 line, -1 line 0 comments Download
M ui/file_manager/audio_player/audio_player.html View 2 chunks +8 lines, -164 lines 0 comments Download
A ui/file_manager/audio_player/elements/audio_player.html View 1 chunk +25 lines, -0 lines 0 comments Download
A ui/file_manager/audio_player/elements/control_panel.html View 1 chunk +113 lines, -0 lines 0 comments Download
A ui/file_manager/audio_player/elements/track_list.html View 1 chunk +23 lines, -0 lines 0 comments Download
A ui/file_manager/audio_player/elements/volume_controller.html View 1 chunk +23 lines, -0 lines 0 comments Download
M ui/file_manager/audio_player/js/audio_player_scripts.js View 2 chunks +0 lines, -7 lines 0 comments Download
M ui/file_manager/file_manager_resources.grd View 1 chunk +12 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
fukino
yoshiki@, could you take a look? Sorry for sending many CLs... Thanks for reviews!
5 years, 6 months ago (2015-06-04 09:15:39 UTC) #2
yoshiki
lgtm
5 years, 6 months ago (2015-06-08 02:19:51 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1164983003/1
5 years, 6 months ago (2015-06-08 02:22:03 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 6 months ago (2015-06-08 03:20:50 UTC) #6
commit-bot: I haz the power
5 years, 6 months ago (2015-06-08 03:21:46 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9123eef92f22dd054fae62234d513916f3e54d49
Cr-Commit-Position: refs/heads/master@{#333236}

Powered by Google App Engine
This is Rietveld 408576698