chrome/android/java_staging/src/org/chromium/chrome/browser/omaha/UpdateInfoBarHelper.java - Issue 1164973003: Add initial support for runtime permissions in android M.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java_staging/src/org/chromium/chrome/browser/omaha/UpdateInfoBarHelper.java

Issue 1164973003: Add initial support for runtime permissions in android M. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address dfalcantara's comments Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/android/java/src/org/chromium/chrome/browser/infobar/ConfirmInfoBar.java ('K') | « chrome/android/java_staging/src/org/chromium/chrome/browser/omaha/OmahaUpdateInfobar.java ('k') | chrome/android/shell/java/src/org/chromium/chrome/shell/ChromeShellActivity.java » ('j') | chrome/browser/ui/android/infobars/confirm_infobar.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java_staging/src/org/chromium/chrome/browser/omaha/UpdateInfoBarHelper.java

diff --git a/chrome/android/java_staging/src/org/chromium/chrome/browser/omaha/UpdateInfoBarHelper.java b/chrome/android/java_staging/src/org/chromium/chrome/browser/omaha/UpdateInfoBarHelper.java

index fed3985ba8a0665efb3fadb1939f0cae5fef560a..12339a42ade85e09f6d7dc4779205635154307b3 100644

--- a/chrome/android/java_staging/src/org/chromium/chrome/browser/omaha/UpdateInfoBarHelper.java

+++ b/chrome/android/java_staging/src/org/chromium/chrome/browser/omaha/UpdateInfoBarHelper.java

@@ -76,8 +76,8 @@ public class UpdateInfoBarHelper {

Resources resources = activity.getResources();

String message = resources.getString(R.string.update_available_infobar);

String button = resources.getString(R.string.update_available_infobar_button);

- OmahaUpdateInfobar updateBar =

- new OmahaUpdateInfobar(activity, message, button, mUpdateURL);

+ OmahaUpdateInfobar updateBar = new OmahaUpdateInfobar(

Bernhard Bauer 2015/06/05 08:34:04 Nit: This change seems to be purely cosmetic?

Ted C 2015/06/05 16:35:30 Was cruft left behind from a previous version wher

+ activity, message, button, mUpdateURL);

currentTab.getInfoBarContainer().addInfoBar(updateBar);

mMustShowInfoBar = false;

}