Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(82)

Issue 1164963002: Fix html_viewer build after latest blink roll (Closed)

Created:
5 years, 6 months ago by Ben Goodger (Google)
Modified:
5 years, 6 months ago
Reviewers:
sky, dcheng
CC:
chromium-reviews, lfg
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix html_viewer build after latest blink roll TBR=sky@chromium.org BUG= Committed: https://crrev.com/927e7e577a0f9680f008971624a58809f25068b2 Cr-Commit-Position: refs/heads/master@{#332728}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -6 lines) Patch
M components/html_viewer/html_document.h View 1 chunk +0 lines, -1 line 0 comments Download
M components/html_viewer/html_document.cc View 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 12 (2 generated)
Ben Goodger (Google)
5 years, 6 months ago (2015-06-03 23:22:00 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1164963002/1
5 years, 6 months ago (2015-06-03 23:22:58 UTC) #3
sky
LGTM
5 years, 6 months ago (2015-06-03 23:23:12 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 6 months ago (2015-06-03 23:40:52 UTC) #5
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/927e7e577a0f9680f008971624a58809f25068b2 Cr-Commit-Position: refs/heads/master@{#332728}
5 years, 6 months ago (2015-06-03 23:42:51 UTC) #6
dcheng
Next time, can you please CC the dev who made this change? We purposely made ...
5 years, 6 months ago (2015-06-11 21:38:54 UTC) #8
Ben Goodger (Google)
On 2015/06/11 21:38:54, dcheng wrote: > Next time, can you please CC the dev who ...
5 years, 6 months ago (2015-06-11 21:40:04 UTC) #9
sky
I will try and remember that in the future. Sorry. -Scott On Thu, Jun 11, ...
5 years, 6 months ago (2015-06-11 21:44:37 UTC) #10
dcheng
Do you happen to remember what the original build failure was? I tried reverting this ...
5 years, 6 months ago (2015-06-11 21:49:36 UTC) #11
dcheng
5 years, 6 months ago (2015-06-11 22:31:34 UTC) #12
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1184543002/ by dcheng@chromium.org.

The reason for reverting is: Reland to unblock Blink..

Powered by Google App Engine
This is Rietveld 408576698