Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(6)

Issues Search
Open Issues | Closed Issues | All Issues | Sign in with your Google Account to create issues and add comments

Issue 1164933008: [DevTools] Extract DeviceModeButton from AdvancedApp. (Closed)

Created:
4 years, 10 months ago by dgozman
Modified:
4 years, 10 months ago
Reviewers:
sergeyv, pfeldman
CC:
blink-reviews, caseq+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, kozyatinskiy+blink_chromium.org
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

[DevTools] Extract DeviceModeButton from AdvancedApp. BUG=none Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=196775

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+92 lines, -89 lines) Patch
M Source/devtools/devtools.gypi View 1 chunk +1 line, -0 lines 0 comments Download
A Source/devtools/front_end/emulation/DeviceModeButton.js View 1 chunk +67 lines, -0 lines 0 comments Download
M Source/devtools/front_end/emulation/module.json View 2 chunks +24 lines, -0 lines 0 comments Download
M Source/devtools/front_end/main/AdvancedApp.js View 3 chunks +0 lines, -66 lines 0 comments Download
M Source/devtools/front_end/main/module.json View 2 chunks +0 lines, -23 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
dgozman
Take a look please.
4 years, 10 months ago (2015-06-08 17:46:50 UTC) #2
pfeldman
lgtm
4 years, 10 months ago (2015-06-08 17:51:18 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1164933008/1
4 years, 10 months ago (2015-06-09 12:03:35 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: win_blink_rel on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/65848)
4 years, 10 months ago (2015-06-09 14:37:20 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1164933008/1
4 years, 10 months ago (2015-06-09 14:48:07 UTC) #9
commit-bot: I haz the power
4 years, 10 months ago (2015-06-09 15:40:59 UTC) #10
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=196775

Powered by Google App Engine
This is Rietveld 408576698