Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(367)

Issue 1164933005: Check for null and undefined when getting type name for stack trace. (Closed)

Created:
5 years, 6 months ago by Yang
Modified:
5 years, 6 months ago
Reviewers:
Sven Panne
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Check for null and undefined when getting type name for stack trace. R=svenpanne@chromium.org BUG=v8:3718 LOG=N Committed: https://crrev.com/f2cce3c41f6673f41a90e730911b6f582b8baa26 Cr-Commit-Position: refs/heads/master@{#28840}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -0 lines) Patch
M src/messages.js View 1 chunk +1 line, -0 lines 0 comments Download
A test/mjsunit/regress/regress-3718.js View 1 chunk +21 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
Yang
5 years, 6 months ago (2015-06-08 11:12:25 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1164933005/1
5 years, 6 months ago (2015-06-08 11:14:07 UTC) #3
Sven Panne
lgtm
5 years, 6 months ago (2015-06-08 11:17:33 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 6 months ago (2015-06-08 11:51:49 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1164933005/1
5 years, 6 months ago (2015-06-08 13:00:03 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 6 months ago (2015-06-08 13:02:23 UTC) #9
commit-bot: I haz the power
5 years, 6 months ago (2015-06-08 13:02:39 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f2cce3c41f6673f41a90e730911b6f582b8baa26
Cr-Commit-Position: refs/heads/master@{#28840}

Powered by Google App Engine
This is Rietveld 408576698