Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(763)

Unified Diff: Source/core/dom/LayoutTreeBuilder.h

Issue 1164923002: Enable ancient assert in LayoutTreeBuilder. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/dom/LayoutTreeBuilder.h
diff --git a/Source/core/dom/LayoutTreeBuilder.h b/Source/core/dom/LayoutTreeBuilder.h
index 6204e801d43f2c8085863c4aeb749cb9a62ab8e1..4a4a11f700812e2a61bb102df1435713f25527a8 100644
--- a/Source/core/dom/LayoutTreeBuilder.h
+++ b/Source/core/dom/LayoutTreeBuilder.h
@@ -48,12 +48,7 @@ protected:
ASSERT(!node.layoutObject());
ASSERT(node.needsAttach());
ASSERT(node.document().inStyleRecalc());
-
- // FIXME: We should be able to ASSERT(node->inActiveDocument()) but childrenChanged is called
- // before ChildNodeInsertionNotifier in ContainerNode's methods and some implementations
- // will trigger a layout inside childrenChanged.
- // Mainly HTMLTextAreaElement::childrenChanged calls HTMLTextFormControlElement::setSelectionRange
- // which does an updateLayoutIgnorePendingStylesheets.
+ ASSERT(node.inActiveDocument());
}
LayoutObject* nextLayoutObject() const
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698