Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(3)

Issue 1164923002: Enable ancient assert in LayoutTreeBuilder. (Closed)

Created:
4 years, 11 months ago by esprehn
Modified:
4 years, 11 months ago
Reviewers:
dglazkov, ojan
CC:
blink-reviews, blink-reviews-dom_chromium.org, dglazkov+blink, eae+blinkwatch, rwlbuis, sof
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Enable ancient assert in LayoutTreeBuilder. We now run ::childrenChanged after ::insertedInto specifically for this reason so that the tree state bits like inDocument are in a consistent state before calling into childrenChanged or code that would otherwise cause a layout. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=196427

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -6 lines) Patch
M Source/core/dom/LayoutTreeBuilder.h View 1 chunk +1 line, -6 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
esprehn
4 years, 11 months ago (2015-06-03 19:22:14 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1164923002/1
4 years, 11 months ago (2015-06-03 19:22:30 UTC) #4
dglazkov
On 2015/06/03 at 19:22:30, commit-bot wrote: > Dry run: CQ is trying da patch. Follow ...
4 years, 11 months ago (2015-06-03 19:27:01 UTC) #5
dglazkov
lgtm
4 years, 11 months ago (2015-06-03 19:27:05 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1164923002/1
4 years, 11 months ago (2015-06-03 19:33:36 UTC) #9
commit-bot: I haz the power
4 years, 11 months ago (2015-06-03 20:34:01 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=196427

Powered by Google App Engine
This is Rietveld 408576698