Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(104)

Unified Diff: chrome/browser/chromeos/login/user_manager_impl.cc

Issue 11649055: OAuth2 sign-in flow for ChromeOS (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: clang fix Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/login/user_manager_impl.cc
diff --git a/chrome/browser/chromeos/login/user_manager_impl.cc b/chrome/browser/chromeos/login/user_manager_impl.cc
index 5ec64029a70475ae46b4ad44655d1fac17731924..b8c1b04ed550d35cfc499d616d9655fb8e04afd1 100644
--- a/chrome/browser/chromeos/login/user_manager_impl.cc
+++ b/chrome/browser/chromeos/login/user_manager_impl.cc
@@ -401,23 +401,15 @@ User::OAuthTokenStatus UserManagerImpl::LoadUserOAuthStatus(
const std::string& username) const {
DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
- if (CommandLine::ForCurrentProcess()->HasSwitch(
- switches::kSkipOAuthLogin)) {
- // Use OAUTH_TOKEN_STATUS_VALID flag if kSkipOAuthLogin is present.
- return User::OAUTH_TOKEN_STATUS_VALID;
- } else {
- PrefService* local_state = g_browser_process->local_state();
- const DictionaryValue* prefs_oauth_status =
- local_state->GetDictionary(kUserOAuthTokenStatus);
-
- int oauth_token_status = User::OAUTH_TOKEN_STATUS_UNKNOWN;
- if (prefs_oauth_status &&
- prefs_oauth_status->GetIntegerWithoutPathExpansion(username,
- &oauth_token_status)) {
- return static_cast<User::OAuthTokenStatus>(oauth_token_status);
- }
+ PrefService* local_state = g_browser_process->local_state();
+ const DictionaryValue* prefs_oauth_status =
+ local_state->GetDictionary(kUserOAuthTokenStatus);
+ int oauth_token_status = User::OAUTH_TOKEN_STATUS_UNKNOWN;
+ if (prefs_oauth_status &&
+ prefs_oauth_status->GetIntegerWithoutPathExpansion(
+ username, &oauth_token_status)) {
+ return static_cast<User::OAuthTokenStatus>(oauth_token_status);
}
-
return User::OAUTH_TOKEN_STATUS_UNKNOWN;
}
@@ -530,8 +522,11 @@ void UserManagerImpl::OnStateChanged() {
// TODO(altimofeev): this code isn't needed after crosbug.com/25978 is
// implemented.
DVLOG(1) << "Invalidate OAuth token because of a sync error.";
- SaveUserOAuthStatus(logged_in_user_->email(),
- User::OAUTH_TOKEN_STATUS_INVALID);
+ SaveUserOAuthStatus(
+ logged_in_user_->email(),
+ CommandLine::ForCurrentProcess()->HasSwitch(::switches::kForceOAuth1) ?
+ User::OAUTH1_TOKEN_STATUS_INVALID :
+ User::OAUTH2_TOKEN_STATUS_INVALID);
}
}

Powered by Google App Engine
This is Rietveld 408576698