OAuth2 sign-in flow for ChromeOS

chrome/browser/chromeos/login/user_manager_impl.cc

Index: chrome/browser/chromeos/login/user_manager_impl.cc
diff --git a/chrome/browser/chromeos/login/user_manager_impl.cc b/chrome/browser/chromeos/login/user_manager_impl.cc
index 5ec64029a70475ae46b4ad44655d1fac17731924..c9c9437d9f429234127512bab70824012f899bdc 100644
--- a/chrome/browser/chromeos/login/user_manager_impl.cc
+++ b/chrome/browser/chromeos/login/user_manager_impl.cc
@@ -401,23 +401,15 @@ User::OAuthTokenStatus UserManagerImpl::LoadUserOAuthStatus(
     const std::string& username) const {
   DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
 
-  if (CommandLine::ForCurrentProcess()->HasSwitch(
-      switches::kSkipOAuthLogin)) {
-    // Use OAUTH_TOKEN_STATUS_VALID flag if kSkipOAuthLogin is present.
-    return User::OAUTH_TOKEN_STATUS_VALID;
-  } else {
-    PrefService* local_state = g_browser_process->local_state();
-    const DictionaryValue* prefs_oauth_status =
-        local_state->GetDictionary(kUserOAuthTokenStatus);
-
-    int oauth_token_status = User::OAUTH_TOKEN_STATUS_UNKNOWN;
-    if (prefs_oauth_status &&
-        prefs_oauth_status->GetIntegerWithoutPathExpansion(username,
-            &oauth_token_status)) {
-      return static_cast<User::OAuthTokenStatus>(oauth_token_status);
-    }
+  PrefService* local_state = g_browser_process->local_state();
+  const DictionaryValue* prefs_oauth_status =
+      local_state->GetDictionary(kUserOAuthTokenStatus);
+  int oauth_token_status = User::OAUTH_TOKEN_STATUS_UNKNOWN;
+  if (prefs_oauth_status &&
+      prefs_oauth_status->GetIntegerWithoutPathExpansion(
+          username, &oauth_token_status)) {
+    return static_cast<User::OAuthTokenStatus>(oauth_token_status);
   }
-
   return User::OAUTH_TOKEN_STATUS_UNKNOWN;
 }
 
@@ -531,7 +523,7 @@ void UserManagerImpl::OnStateChanged() {
     // implemented.
     DVLOG(1) << "Invalidate OAuth token because of a sync error.";

[Nikita (slow), 2013/01/11 22:02:03]

LOG(WARNING) << OAuth1

[zel, 2013/01/12 02:07:37]

The comment was good, the code below wasn't.

     SaveUserOAuthStatus(logged_in_user_->email(),
-                        User::OAUTH_TOKEN_STATUS_INVALID);
+                        User::OAUTH1_TOKEN_STATUS_INVALID);
   }
 }