OAuth2 sign-in flow for ChromeOS

chrome/browser/chromeos/login/login_performer.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/chromeos/login/login_performer.h"
 
 #include <string>
 
 #include "base/bind.h"
 #include "base/command_line.h"

[Joao da Silva, 2013/01/11 16:45:07]

Not needed

[zel, 2013/01/11 19:51:16]

Done.

 #include "base/logging.h"
 #include "base/message_loop.h"
 #include "base/metrics/histogram.h"
 #include "base/threading/thread_restrictions.h"
 #include "base/utf_string_conversions.h"
 #include "chrome/browser/browser_process.h"
 #include "chrome/browser/chromeos/boot_times_loader.h"
 #include "chrome/browser/chromeos/login/login_utils.h"
 #include "chrome/browser/chromeos/login/screen_locker.h"
 #include "chrome/browser/chromeos/settings/cros_settings.h"
 #include "chrome/browser/chromeos/settings/cros_settings_names.h"
 #include "chrome/browser/policy/browser_policy_connector.h"
 #include "chrome/browser/policy/device_local_account_policy_service.h"
 #include "chrome/browser/prefs/pref_service.h"
 #include "chrome/browser/profiles/profile.h"
 #include "chrome/browser/profiles/profile_manager.h"
 #include "chrome/common/chrome_notification_types.h"
 #include "chrome/common/chrome_switches.h"

[Joao da Silva, 2013/01/11 16:45:07]

Not needed

[zel, 2013/01/11 19:51:16]

Done.

 #include "chrome/common/pref_names.h"
 #include "chromeos/dbus/dbus_thread_manager.h"
 #include "chromeos/dbus/session_manager_client.h"
 #include "content/public/browser/browser_thread.h"
 #include "content/public/browser/notification_service.h"
 #include "content/public/browser/notification_types.h"
 #include "content/public/browser/user_metrics.h"
 #include "google_apis/gaia/gaia_auth_util.h"
 #include "grit/generated_resources.h"
 #include "net/cookies/cookie_monster.h"
@@ skipping 14 matching lines @@
 
 LoginPerformer::LoginPerformer(Delegate* delegate)
     : ALLOW_THIS_IN_INITIALIZER_LIST(online_attempt_host_(this)),
       last_login_failure_(LoginFailure::None()),
       delegate_(delegate),
       password_changed_(false),
       password_changed_callback_count_(0),
       screen_lock_requested_(false),
       initial_online_auth_pending_(false),
       auth_mode_(AUTH_MODE_INTERNAL),
-      using_oauth_(
-          !CommandLine::ForCurrentProcess()->HasSwitch(
-              switches::kSkipOAuthLogin)),
       ALLOW_THIS_IN_INITIALIZER_LIST(weak_factory_(this)) {
   DCHECK(default_performer_ == NULL)
       << "LoginPerformer should have only one instance.";
   default_performer_ = this;
 }
 
 LoginPerformer::~LoginPerformer() {
   DVLOG(1) << "Deleting LoginPerformer";
   DCHECK(default_performer_ != NULL) << "Default instance should exist.";
   default_performer_ = NULL;
@@ skipping 107 matching lines @@
     case Profile::CREATE_STATUS_INITIALIZED:
       break;
     case Profile::CREATE_STATUS_CREATED:
       return;
     case Profile::CREATE_STATUS_FAIL:
     default:
       NOTREACHED();
       return;
   }
 
-  if (using_oauth_)
-    LoginUtils::Get()->StartTokenServices(profile);
+  // TODO(zelidrag): Figure out when this needs to run.
+  LoginUtils::Get()->StartTokenServices(profile);

[Joao da Silva, 2013/01/11 16:45:07]

AFAICT this method is dead code.

It's only used as the callback for CreateDefaultProfileAsync above. However,
that is only posted when |delegate_| is NULL, which I think that never happens.

LoginPerformer is only created by existing_user_controller.cc, and it always
sets the ExistingUserController as the delegate (except for tests). It only
removes the delegate at ExistingUserController::OnLoginSuccess(), but it deletes
the LoginPerformer immediately after.

In any case, StartTokenServices is currently only starting the fetch of the
oauth token for the policy server. This is usually handled by
LoginUtils::PrepareProfile() or LoginUtils::OnProfileCreated(). If there is no
|delegate_| here then this should be invoked here; but AFAICT this method is
never used.

[zel, 2013/01/11 19:51:16]

I suspect this might have something to do with screen locker then. Nikita might
know better. I will be happy to nuke it if I can't find when its being used.

[Nikita (slow), 2013/01/11 22:02:03]

Yes, this method could be removed.

[zel, 2013/01/12 02:07:36]

Removed LoginPerformer::OnProfileCreated(), branch of delegate_==NULL in
LoginPerformer::OnLoginSuccess() and removed LoginUtils::StartTokenServices().

 
   // Don't unlock screen if it was locked while we're waiting
   // for initial online auth.
   if (ScreenLocker::default_screen_locker() &&
       !initial_online_auth_pending_) {
     DVLOG(1) << "Online login OK - unlocking screen.";
     RequestScreenUnlock();
     // Do not delete itself just yet, wait for unlock.
     // See ResolveScreenUnlocked().
     return;
@@ skipping 354 matching lines @@
                    profile,
                    username_,
                    password_,
                    std::string(),
                    std::string()));
   }
   password_.clear();
 }
 
 }  // namespace chromeos