OAuth2 sign-in flow for ChromeOS

chrome/browser/chromeos/login/oauth2_login_verifier.h

+// Copyright (c) 2012 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CHROME_BROWSER_CHROMEOS_LOGIN_OAUTH2_LOGIN_VERIFIER_H_
+#define CHROME_BROWSER_CHROMEOS_LOGIN_OAUTH2_LOGIN_VERIFIER_H_
+
+#include <string>
+
+#include "base/basictypes.h"
+#include "base/callback.h"

[xiyuan, 2013/01/07 23:07:55]

callback.h is probably not needed. And you might need to add "base/bind.h" to cc
file after removing this.

+#include "base/compiler_specific.h"
+#include "base/memory/weak_ptr.h"
+#include "google_apis/gaia/gaia_auth_consumer.h"
+#include "google_apis/gaia/gaia_auth_fetcher.h"
+#include "google_apis/gaia/oauth2_access_token_consumer.h"
+#include "google_apis/gaia/oauth2_access_token_fetcher.h"
+
+class Profile;
+
+namespace chromeos {
+
+// Given the authenticated credentials from the cookie jar, try to exchange
+// fetch OAuth1 token+secret and then set of GAIA credentials (SID/LSID) that
+// can be used for other token fetching calls (i.e. TokenService).

[xiyuan, 2013/01/07 23:07:55]

Update the comments?

[zel, 2013/01/08 02:05:41]

Done.

+class OAuth2LoginVerifier : public base::SupportsWeakPtr<OAuth2LoginVerifier>,
+                            public GaiaAuthConsumer,
+                            public OAuth2AccessTokenConsumer {
+ public:
+  class Delegate {
+   public:
+    virtual ~Delegate() {}
+    virtual void OnOAuth2LoginVerifierSuccess(const std::string& sid,
+                                              const std::string& lsid,
+                                              const std::string& auth) = 0;
+    virtual void OnOAuth2LoginVerifierFaulure() = 0;
+  };
+
+  OAuth2LoginVerifier(OAuth2LoginVerifier::Delegate* delegate,
+                      net::URLRequestContextGetter* system_request_context,
+                      Profile* user_profile);
+  virtual ~OAuth2LoginVerifier();
+
+  void VerifyRefreshToken(const std::string& refresh_token);
+
+ private:
+  // GaiaAuthConsumer overrides.
+  virtual void OnClientLoginSuccess(const ClientLoginResult& result) OVERRIDE;
+  virtual void OnClientLoginFailure(
+      const GoogleServiceAuthError& error) OVERRIDE;
+  virtual void OnIssueAuthTokenSuccess(const std::string& service,
+                                       const std::string& auth_token) OVERRIDE;
+  virtual void OnIssueAuthTokenFailure(
+      const std::string& service, const GoogleServiceAuthError& error) OVERRIDE;
+  virtual void OnMergeSessionSuccess(const std::string& data) OVERRIDE;
+  virtual void OnMergeSessionFailure(
+      const GoogleServiceAuthError& error) OVERRIDE;
+
+  // OAuth2AccessTokenConsumer overrides.
+  virtual void OnGetTokenSuccess(const std::string& access_token,
+                                 const base::Time& expiration_time) OVERRIDE;
+  virtual void OnGetTokenFailure(const GoogleServiceAuthError& error) OVERRIDE;
+
+  // Starts OAuthLogin request.
+  void StartOAuthLogin();
+
+  // Starts sequence of calls (IssueAuthToken, MergeSession) for exchanging
+  // OAuth2 access token for GAIA cookies.
+  void StartCookiesRetrieval();
+
+  // Decides how to proceed on GAIA |error|. If the error looks temporary,
+  // retries |task| after certain delY until max retry count is reached.

[xiyuan, 2013/01/07 23:07:55]

nit: delY -> delay

[zel, 2013/01/08 02:05:41]

Done.

+  void RetryOnError(const char* operation_id,
+                    const GoogleServiceAuthError& error,
+                    const base::Closure& task);
+
+  OAuth2LoginVerifier::Delegate* delegate_;
+  Profile* auth_profile_;

[xiyuan, 2013/01/07 23:07:55]

|auth_profile_| seems not used.

[zel, 2013/01/08 02:05:41]

Done.

+  OAuth2AccessTokenFetcher token_fetcher_;
+  GaiaAuthFetcher gaia_fetcher_;
+  std::string access_token_;
+  std::string refresh_token_;
+  std::string sid_;
+  std::string lsid_;
+  std::string token_;
+  // The retry counter. Increment this only when failure happened.
+  int retry_count_;
+
+  DISALLOW_COPY_AND_ASSIGN(OAuth2LoginVerifier);
+};
+
+}  // namespace chromeos
+
+#endif  // CHROME_BROWSER_CHROMEOS_LOGIN_OAUTH2_LOGIN_VERIFIER_H_