chrome/browser/profiles/profile_dependency_manager.cc - Issue 11649053: Banish boilerplate. Profile-keyed API factory for extension API classes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/profiles/profile_dependency_manager.cc

Issue 11649053: Banish boilerplate. Profile-keyed API factory for extension API classes. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 8 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/extensions/api/profile_keyed_api_factory.h ('K') | « chrome/browser/extensions/api/tabs/tabs_windows_api_factory.cc ('k') | chrome/chrome_browser_extensions.gypi » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/profiles/profile_dependency_manager.cc

diff --git a/chrome/browser/profiles/profile_dependency_manager.cc b/chrome/browser/profiles/profile_dependency_manager.cc

index 3a9575fdf873b2bee7fc301de126f885ba013440..0216a5d3c039b9defa12d9cf027620a548b1d517 100644

--- a/chrome/browser/profiles/profile_dependency_manager.cc

+++ b/chrome/browser/profiles/profile_dependency_manager.cc

@@ -28,10 +28,11 @@

#include "chrome/browser/extensions/api/media_galleries_private/media_galleries_private_api_factory.h"

#include "chrome/browser/extensions/api/omnibox/omnibox_api_factory.h"

#include "chrome/browser/extensions/api/preference/preference_api_factory.h"

-#include "chrome/browser/extensions/api/processes/processes_api_factory.h"

+#include "chrome/browser/extensions/api/processes/processes_api.h"

+#include "chrome/browser/extensions/api/profile_keyed_api_factory.h"

#include "chrome/browser/extensions/api/push_messaging/push_messaging_api_factory.h"

#include "chrome/browser/extensions/api/tab_capture/tab_capture_registry_factory.h"

-#include "chrome/browser/extensions/api/tabs/tabs_windows_api_factory.h"

+#include "chrome/browser/extensions/api/tabs/tabs_windows_api.h"

#include "chrome/browser/extensions/api/web_navigation/web_navigation_api_factory.h"

#include "chrome/browser/extensions/app_restore_service_factory.h"

#include "chrome/browser/extensions/extension_system_factory.h"

@@ -256,12 +257,12 @@ void ProfileDependencyManager::AssertFactoriesBuilt() {

extensions::ManagedModeAPIFactory::GetInstance();

extensions::MediaGalleriesPrivateAPIFactory::GetInstance();

extensions::OmniboxAPIFactory::GetInstance();

+ extensions::ProfileKeyedAPIFactory<extensions::ProcessesAPI>::GetInstance();

extensions::PreferenceAPIFactory::GetInstance();

- extensions::ProcessesAPIFactory::GetInstance();

extensions::PushMessagingAPIFactory::GetInstance();

extensions::SuggestedLinksRegistryFactory::GetInstance();

extensions::TabCaptureRegistryFactory::GetInstance();

- extensions::TabsWindowsAPIFactory::GetInstance();

+ extensions::ProfileKeyedAPIFactory<extensions::TabsWindowsAPI>::GetInstance();

Jeffrey Yasskin 2012/12/21 01:43:50 Sort these?

Yoyo Zhou 2012/12/21 22:41:33 Done.

extensions::WebNavigationAPIFactory::GetInstance();

ExtensionManagementAPIFactory::GetInstance();

#endif