Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2671)

Unified Diff: base/threading/sequenced_worker_pool_unittest.cc

Issue 11649032: Flush SequenceWorkerPool tasks after each unit test. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: base/threading/sequenced_worker_pool_unittest.cc
===================================================================
--- base/threading/sequenced_worker_pool_unittest.cc (revision 176718)
+++ base/threading/sequenced_worker_pool_unittest.cc (working copy)
@@ -701,8 +701,8 @@
}
void StopTaskRunner() {
- // Make sure all tasks (including delayed ones) are run before shutting
- // down.
+ // Make sure all tasks are run before shutting down. Delayed tasks are
+ // not run, they're simply deleted.
pool_owner_->pool()->FlushForTesting();
pool_owner_->pool()->Shutdown();
// Don't reset |pool_owner_| here, as the test may still hold a
@@ -741,8 +741,8 @@
}
void StopTaskRunner() {
- // Make sure all tasks (including delayed ones) are run before shutting
- // down.
+ // Make sure all tasks are run before shutting down. Delayed tasks are
+ // not run, they're simply deleted.
pool_owner_->pool()->FlushForTesting();
pool_owner_->pool()->Shutdown();
// Don't reset |pool_owner_| here, as the test may still hold a
@@ -782,8 +782,8 @@
}
void StopTaskRunner() {
- // Make sure all tasks (including delayed ones) are run before shutting
- // down.
+ // Make sure all tasks are run before shutting down. Delayed tasks are
+ // not run, they're simply deleted.
pool_owner_->pool()->FlushForTesting();
pool_owner_->pool()->Shutdown();
// Don't reset |pool_owner_| here, as the test may still hold a

Powered by Google App Engine
This is Rietveld 408576698