Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3054)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: base/threading/sequenced_worker_pool.h

Issue 11649032: Flush SequenceWorkerPool tasks after each unit test. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« base/test/task_runner_test_template.h ('K') | « base/test/task_runner_test_template.cc ('k') | base/threading/sequenced_worker_pool.cc » ('j') | base/threading/sequenced_worker_pool.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/threading/sequenced_worker_pool.h
===================================================================
--- base/threading/sequenced_worker_pool.h (revision 183651)
+++ base/threading/sequenced_worker_pool.h (working copy)
@@ -288,6 +288,7 @@
// Blocks until all pending tasks are complete. This should only be called in
// unit tests when you want to validate something that should have happened.
+ // This will not flush delayed tasks, delayed tasks get deleted.
akalin 2013/02/26 00:12:23 semi-colon instead of comma
michaeln 2013/02/27 00:57:12 Done.
//
// Note that calling this will not prevent other threads from posting work to
// the queue while the calling thread is waiting on Flush(). In this case,
« base/test/task_runner_test_template.h ('K') | « base/test/task_runner_test_template.cc ('k') | base/threading/sequenced_worker_pool.cc » ('j') | base/threading/sequenced_worker_pool.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698