Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(115)

Issue 11649008: Reorganize Android's test scripts into packages. (Closed)

Created:
8 years ago by frankf
Modified:
7 years, 11 months ago
CC:
chromium-reviews, ilevy+watch_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org, peter+watch_chromium.org, klundberg+watch_chromium.org, frankf+watch_chromium.org
Visibility:
Public.

Description

Reorganize Android's test scripts into packages. This is the first attempt at splitting the scripts into meaningful packages and make dependencies explicit. BUG=167331 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=175441

Patch Set 1 #

Patch Set 2 : python_driven -> host_driven, rebased #

Patch Set 3 : Rebase again #

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+59 lines, -2705 lines) Patch
D build/android/pylib/apk_info.py View 1 chunk +0 lines, -186 lines 0 comments Download
D build/android/pylib/debug_info.py View 1 chunk +0 lines, -196 lines 0 comments Download
A + build/android/pylib/gtest/__init__.py View 0 chunks +-1 lines, --1 lines 0 comments Download
A + build/android/pylib/gtest/debug_info.py View 1 chunk +1 line, -1 line 0 comments Download
A + build/android/pylib/gtest/single_test_runner.py View 1 2 1 chunk +8 lines, -7 lines 0 comments Download
A + build/android/pylib/gtest/test_package.py View 1 chunk +4 lines, -5 lines 0 comments Download
A + build/android/pylib/gtest/test_package_apk.py View 1 chunk +6 lines, -4 lines 0 comments Download
A + build/android/pylib/gtest/test_package_executable.py View 1 chunk +4 lines, -3 lines 0 comments Download
A + build/android/pylib/host_driven/__init__.py View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + build/android/pylib/host_driven/java_unittest_utils.py View 1 1 chunk +2 lines, -2 lines 0 comments Download
A + build/android/pylib/host_driven/python_test_base.py View 1 1 chunk +4 lines, -4 lines 0 comments Download
A + build/android/pylib/host_driven/python_test_caller.py View 1 1 chunk +1 line, -1 line 0 comments Download
A + build/android/pylib/host_driven/python_test_sharder.py View 1 1 chunk +4 lines, -3 lines 0 comments Download
A + build/android/pylib/host_driven/run_python_tests.py View 1 1 chunk +7 lines, -6 lines 0 comments Download
A + build/android/pylib/host_driven/test_info_collection.py View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + build/android/pylib/host_driven/tests_annotations.py View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + build/android/pylib/instrumentation/__init__.py View 0 chunks +-1 lines, --1 lines 0 comments Download
A + build/android/pylib/instrumentation/apk_info.py View 1 chunk +2 lines, -1 line 0 comments Download
A + build/android/pylib/instrumentation/run_java_tests.py View 1 chunk +14 lines, -12 lines 0 comments Download
D build/android/pylib/java_unittest_utils.py View 1 chunk +0 lines, -27 lines 0 comments Download
D build/android/pylib/python_test_base.py View 1 chunk +0 lines, -172 lines 0 comments Download
D build/android/pylib/python_test_caller.py View 1 chunk +0 lines, -84 lines 0 comments Download
D build/android/pylib/python_test_sharder.py View 1 chunk +0 lines, -203 lines 0 comments Download
D build/android/pylib/run_java_tests.py View 1 chunk +0 lines, -593 lines 0 comments Download
D build/android/pylib/run_python_tests.py View 1 chunk +0 lines, -207 lines 0 comments Download
D build/android/pylib/single_test_runner.py View 1 2 1 chunk +0 lines, -293 lines 0 comments Download
D build/android/pylib/test_info_collection.py View 1 chunk +0 lines, -137 lines 0 comments Download
D build/android/pylib/test_package.py View 1 chunk +0 lines, -184 lines 0 comments Download
D build/android/pylib/test_package_apk.py View 1 chunk +0 lines, -120 lines 0 comments Download
D build/android/pylib/test_package_executable.py View 1 chunk +0 lines, -163 lines 0 comments Download
D build/android/pylib/tests_annotations.py View 1 chunk +0 lines, -89 lines 0 comments Download
M build/android/run_instrumentation_tests.py View 1 2 3 1 chunk +3 lines, -3 lines 0 comments Download
M build/android/run_monkey_test.py View 1 1 chunk +2 lines, -2 lines 0 comments Download
M build/android/run_tests.py View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
frankf
8 years ago (2012-12-19 02:46:10 UTC) #1
shashi
lgtm If I understand correctly, this is reorganizing the pylib directory in pylib.gtest, pylib.instrumentation, pylib.python_driven. ...
8 years ago (2012-12-19 21:46:27 UTC) #2
craigdh
lgtm. As you brought up offline, should run_tests.py be named run_gtest_tests.py to be more in ...
8 years ago (2012-12-19 22:17:19 UTC) #3
Isaac (away)
Let's get Marcus's input on this before changing.
8 years ago (2012-12-20 06:50:24 UTC) #4
bulach
lgtm good modularization, thanks! points to note: - discussed with ilevy this morning, he'll discuss ...
7 years, 11 months ago (2013-01-07 14:30:27 UTC) #5
frankf
7 years, 11 months ago (2013-01-07 20:10:32 UTC) #6
On 2013/01/07 14:30:27, bulach wrote:
> lgtm
> 
> good modularization, thanks!
> 
> points to note:
> - discussed with ilevy this morning, he'll discuss with you renaming
> "instrumentation" to "junit", so make sure you guys agree and are consistent
:)
> (either way is fine by me).
> 
> - agree with craig, but would remove the  "_test" suffix and just keep
> "run_gtests.py"..

Will do in a separate CL.
> 
> - I don't have any better suggestion, but would appreciate anything for
"python
> driven" tests :)
> maybe "host_driven" tests would be clearer? as in, the test themselves (more
> than just the harness) are driven by the host, unlike the other tests... wdyt?

Good idea -> host_driven.

Powered by Google App Engine
This is Rietveld 408576698