Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3494)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/browser/ui/browser_browsertest.cc

Issue 1164873003: Show origin for hosted apps that navigate away from their start origin. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: feedback for the stig Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/browser.cc ('k') | chrome/browser/ui/extensions/bookmark_app_browser_controller.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/browser_browsertest.cc
diff --git a/chrome/browser/ui/browser_browsertest.cc b/chrome/browser/ui/browser_browsertest.cc
index 9cf66fa789c6debc3f70fd713a11b14051e92f17..451c41f6a835118c6ee113c1dbf6995589c1e8f2 100644
--- a/chrome/browser/ui/browser_browsertest.cc
+++ b/chrome/browser/ui/browser_browsertest.cc
@@ -1415,7 +1415,10 @@ IN_PROC_BROWSER_TEST_F(BrowserTest, ShouldShowLocationBar) {
EXPECT_FALSE(
dev_tools_browser->SupportsWindowFeature(Browser::FEATURE_LOCATIONBAR));
- EXPECT_FALSE(
+
+ // App windows can show location bars, for example when they navigate away
+ // from their starting origin.
+ EXPECT_TRUE(
app_browser->SupportsWindowFeature(Browser::FEATURE_LOCATIONBAR));
DevToolsWindowTesting::CloseDevToolsWindowSync(devtools_window);
« no previous file with comments | « chrome/browser/ui/browser.cc ('k') | chrome/browser/ui/extensions/bookmark_app_browser_controller.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698