chrome/browser/ui/browser_browsertest.cc - Issue 1164873003: Show origin for hosted apps that navigate away from their start origin.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/browser_browsertest.cc

Issue 1164873003: Show origin for hosted apps that navigate away from their start origin. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/browser.cc ('k') | chrome/browser/ui/extensions/bookmark_app_browser_controller.h » ('j') | chrome/browser/ui/extensions/hosted_app_browser_controller.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/browser_browsertest.cc

diff --git a/chrome/browser/ui/browser_browsertest.cc b/chrome/browser/ui/browser_browsertest.cc

index 99cdde01da048a4fcfa4be79cb644192d5c488a1..afba4c210abf2de2f58dfce232efc2939f59aeec 100644

--- a/chrome/browser/ui/browser_browsertest.cc

+++ b/chrome/browser/ui/browser_browsertest.cc

@@ -1415,7 +1415,10 @@ IN_PROC_BROWSER_TEST_F(BrowserTest, ShouldShowLocationBar) {

EXPECT_FALSE(

dev_tools_browser->SupportsWindowFeature(Browser::FEATURE_LOCATIONBAR));

- EXPECT_FALSE(

+ // App windows can show location bars, for example when they navigate away

+ // from their starting origin.

+ EXPECT_TRUE(

app_browser->SupportsWindowFeature(Browser::FEATURE_LOCATIONBAR));

DevToolsWindowTesting::CloseDevToolsWindowSync(devtools_window);