Issue 116483002: Move common prerender_loader code into prerender_events_common.js.

Issue 116483002: Move common prerender_loader code into prerender_events_common.js. (Closed)

Created:
7 years ago by davidben

Modified:
7 years ago

Reviewers:
mmenke

CC:
chromium-reviews, tburkard+watch_chromium.org, gavinp+prer_chromium.org, cbentzel+watch_chromium.org, dominich+watch_chromium.org, davidben+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Move common prerender_loader code into prerender_events_common.js. Some of the loaders on disabled tests have bitrotted. Also use MouseEvent constructor. It's far more readable than the old initMouseEvents. BUG=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=241112

Patch Set 1 #

Total comments: 2

Created: 7 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+92 lines, -96 lines)			Patch
M	chrome/test/data/prerender/prerender_events_common.js	View	1 chunk	+84 lines, -0 lines	2 comments	Download
M	chrome/test/data/prerender/prerender_loader.html	View	1 chunk	+1 line, -63 lines	0 comments	Download
M	chrome/test/data/prerender/prerender_loader_removing_links.html	View	1 chunk	+2 lines, -5 lines	0 comments	Download
M	chrome/test/data/prerender/prerender_loader_with_referrer_policy.html	View	1 chunk	+1 line, -15 lines	0 comments	Download
M	chrome/test/data/prerender/prerender_loader_with_session_storage.html	View	2 chunks	+2 lines, -12 lines	0 comments	Download
M	chrome/test/data/prerender/prerender_loader_with_unload.html	View	2 chunks	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

mmenke

LGTM https://codereview.chromium.org/116483002/diff/1/chrome/test/data/prerender/prerender_events_common.js File chrome/test/data/prerender/prerender_events_common.js (right): https://codereview.chromium.org/116483002/diff/1/chrome/test/data/prerender/prerender_events_common.js#newcode70 chrome/test/data/prerender/prerender_events_common.js:70: detail: 1 What does detail do? Can we ...

7 years ago (2013-12-16 17:48:42 UTC) #2

davidben

https://codereview.chromium.org/116483002/diff/1/chrome/test/data/prerender/prerender_events_common.js File chrome/test/data/prerender/prerender_events_common.js (right): https://codereview.chromium.org/116483002/diff/1/chrome/test/data/prerender/prerender_events_common.js#newcode70 chrome/test/data/prerender/prerender_events_common.js:70: detail: 1 On 2013/12/16 17:48:43, mmenke wrote: > What ...

7 years ago (2013-12-16 18:07:03 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/davidben@chromium.org/116483002/1

7 years ago (2013-12-16 19:56:09 UTC) #4

commit-bot: I haz the power

Retried try job too often on mac_rel for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&number=203343

7 years ago (2013-12-16 22:08:57 UTC) #5

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/davidben@chromium.org/116483002/1

7 years ago (2013-12-16 23:05:48 UTC) #6

Message was sent while issue was closed.

Change committed as 241112

Expand Messages | Collapse Messages