Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1306)

Unified Diff: content/browser/speech/speech_recognizer_impl_unittest.cc

Issue 1164823002: Remove URLRequestStatus mutators and introduce FromError. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/speech/speech_recognizer_impl_unittest.cc
diff --git a/content/browser/speech/speech_recognizer_impl_unittest.cc b/content/browser/speech/speech_recognizer_impl_unittest.cc
index 3e8ef28428748deb7bd715d010ad96f63d063d54..ba6b06ab50f4d64beccb2f533e23f40131114384 100644
--- a/content/browser/speech/speech_recognizer_impl_unittest.cc
+++ b/content/browser/speech/speech_recognizer_impl_unittest.cc
@@ -261,9 +261,7 @@ TEST_F(SpeechRecognizerImplTest, StopWithData) {
ASSERT_TRUE(fetcher);
fetcher->set_url(fetcher->GetOriginalURL());
- net::URLRequestStatus status;
- status.set_status(net::URLRequestStatus::SUCCESS);
- fetcher->set_status(status);
+ fetcher->set_status(net::URLRequestStatus());
fetcher->set_response_code(200);
fetcher->SetResponseString(
"{\"status\":0,\"hypotheses\":[{\"utterance\":\"123\"}]}");
@@ -317,10 +315,8 @@ TEST_F(SpeechRecognizerImplTest, ConnectionError) {
// Issue the network callback to complete the process.
fetcher->set_url(fetcher->GetOriginalURL());
- net::URLRequestStatus status;
- status.set_status(net::URLRequestStatus::FAILED);
- status.set_error(net::ERR_CONNECTION_REFUSED);
- fetcher->set_status(status);
+ fetcher->set_status(
+ net::URLRequestStatus::FromError(net::ERR_CONNECTION_REFUSED));
fetcher->set_response_code(0);
fetcher->SetResponseString(std::string());
fetcher->delegate()->OnURLFetchComplete(fetcher);
@@ -354,9 +350,7 @@ TEST_F(SpeechRecognizerImplTest, ServerError) {
// Issue the network callback to complete the process.
fetcher->set_url(fetcher->GetOriginalURL());
- net::URLRequestStatus status;
- status.set_status(net::URLRequestStatus::SUCCESS);
- fetcher->set_status(status);
+ fetcher->set_status(net::URLRequestStatus());
fetcher->set_response_code(500);
fetcher->SetResponseString("Internal Server Error");
fetcher->delegate()->OnURLFetchComplete(fetcher);

Powered by Google App Engine
This is Rietveld 408576698