content/browser/loader/redirect_to_file_resource_handler.cc - Issue 1164823002: Remove URLRequestStatus mutators and introduce FromError.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/loader/redirect_to_file_resource_handler.cc

Issue 1164823002: Remove URLRequestStatus mutators and introduce FromError. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/domain_reliability/monitor_unittest.cc ('K') | « components/domain_reliability/uploader_unittest.cc ('k') | content/browser/speech/google_one_shot_remote_engine_unittest.cc » ('j') | net/url_request/url_request_status.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/loader/redirect_to_file_resource_handler.cc

diff --git a/content/browser/loader/redirect_to_file_resource_handler.cc b/content/browser/loader/redirect_to_file_resource_handler.cc

index 6f402135c883775bfa0670b64db8e1dd5b4fce30..e87a23bf916f1650a248eeab766ef08b3ef5f593 100644

--- a/content/browser/loader/redirect_to_file_resource_handler.cc

+++ b/content/browser/loader/redirect_to_file_resource_handler.cc

@@ -281,8 +281,8 @@ void RedirectToFileResourceHandler::DidWriteToFile(int result) {

if (completed_during_write_ && completed_status_.is_success()) {

// If the request successfully completed mid-write, but the write failed,

// convert the status to a failure for downstream.

- completed_status_.set_status(net::URLRequestStatus::CANCELED);

- completed_status_.set_error(net::ERR_FAILED);

+ completed_status_ = net::URLRequestStatus(net::URLRequestStatus::CANCELED,

+ net::ERR_FAILED);

}

if (!completed_during_write_)

controller()->CancelWithError(net::ERR_FAILED);