Extract external file systems handling from isolated context.

webkit/fileapi/file_system_url.cc

Index: webkit/fileapi/file_system_url.cc
diff --git a/webkit/fileapi/file_system_url.cc b/webkit/fileapi/file_system_url.cc
index 9e2fdf51b904e9cccc600a2d22a6fb70264c4ad9..2f4696c567eb94807e38d246807cb964c09a3c59 100644
--- a/webkit/fileapi/file_system_url.cc
+++ b/webkit/fileapi/file_system_url.cc
@@ -9,6 +9,7 @@
 #include "base/logging.h"
 #include "base/string_util.h"
 #include "net/base/escape.h"
+#include "webkit/fileapi/external_mount_points.h"
 #include "webkit/fileapi/file_system_types.h"
 #include "webkit/fileapi/file_system_util.h"
 #include "webkit/fileapi/isolated_context.h"
@@ -158,6 +159,10 @@ void FileSystemURL::MayCrackIsolatedPath() {
   if (is_valid_ && IsolatedContext::IsIsolatedType(type_)) {

[kinuko, 2013/01/08 12:22:43]

Maybe we should do like:

if (!is_valid_)
  return;

if (ExternalMountPoints::GetInstance()->CanCrack(type_)) {
  ...
  return;
}
if (IsolatedContext::GetInstance()->CanCrack(type_)) {
  ...
  return;
}

[tbarzic, 2013/01/09 01:26:34]

I plan to do something like this in the next cl
(https://codereview.chromium.org/11787028/ ; note that this one is WIP :) )

     // If the type is isolated, crack the path further to get the 'real'
     // filesystem type and path.
+    is_valid_ = ExternalMountPoints::GetSystemInstance()->CrackExternalPath(
+        virtual_path_, &filesystem_id_, &type_, &path_);
+    if (is_valid_)
+      return;
     is_valid_ = IsolatedContext::GetInstance()->CrackIsolatedPath(
         virtual_path_, &filesystem_id_, &type_, &path_);
   }