Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(140)

Unified Diff: vm/debugger.cc

Issue 11648006: Create read only handles for empty_array and sentinel objects (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/runtime/
Patch Set: Created 8 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « vm/dart_entry_test.cc ('k') | vm/exceptions.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: vm/debugger.cc
===================================================================
--- vm/debugger.cc (revision 16415)
+++ vm/debugger.cc (working copy)
@@ -1145,8 +1145,8 @@
if (!fld.IsNull()) {
// Return the value in the field if it has been initialized already.
const Instance& value = Instance::Handle(fld.value());
- ASSERT(value.raw() != Object::transition_sentinel());
- if (value.raw() != Object::sentinel()) {
+ ASSERT(value.raw() != Object::transition_sentinel().raw());
+ if (value.raw() != Object::sentinel().raw()) {
return value.raw();
}
}
@@ -1166,8 +1166,7 @@
bool saved_ignore_flag = ignore_breakpoints_;
ignore_breakpoints_ = true;
if (setjmp(*jump.Set()) == 0) {
- const Array& args = Array::Handle(Object::empty_array());
- result = DartEntry::InvokeStatic(getter_func, args);
+ result = DartEntry::InvokeStatic(getter_func, Object::empty_array());
} else {
result = isolate_->object_store()->sticky_error();
}
« no previous file with comments | « vm/dart_entry_test.cc ('k') | vm/exceptions.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698