vm/ast.cc - Issue 11648006: Create read only handles for empty_array and sentinel objects

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: vm/ast.cc

Issue 11648006: Create read only handles for empty_array and sentinel objects (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/runtime/

Patch Set: Created 8 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: vm/ast.cc

===================================================================

--- vm/ast.cc (revision 16415)

+++ vm/ast.cc (working copy)

@@ -426,9 +426,8 @@

if (getter_func.IsNull() || !getter_func.is_const()) {

return NULL;

}

- const Array& args = Array::Handle(Object::empty_array());

- const Object& result = Object::Handle(DartEntry::InvokeStatic(getter_func,

- args));

+ const Object& result = Object::Handle(

+ DartEntry::InvokeStatic(getter_func, Object::empty_array()));

if (result.IsError() || result.IsNull()) {

// TODO(turnidge): We could get better error messages by returning

// the Error object directly to the parser. This will involve

« no previous file with comments | « lib/string.cc ('k') | vm/class_finalizer_test.cc » ('j') | no next file with comments »