Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Unified Diff: lib/string.cc

Issue 11648006: Create read only handles for empty_array and sentinel objects (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/runtime/
Patch Set: Created 8 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « lib/isolate.cc ('k') | vm/ast.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: lib/string.cc
===================================================================
--- lib/string.cc (revision 16415)
+++ lib/string.cc (working copy)
@@ -32,8 +32,7 @@
}
intptr_t value = Smi::Cast(index_object).Value();
if (Utf::IsOutOfRange(value)) {
- const Array& args = Array::Handle(Object::empty_array());
- Exceptions::ThrowByType(Exceptions::kArgument, args);
+ Exceptions::ThrowByType(Exceptions::kArgument, Object::empty_array());
} else {
if (!Utf::IsLatin1(value)) {
is_one_byte_string = false;
« no previous file with comments | « lib/isolate.cc ('k') | vm/ast.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698