Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(112)

Issue 1164763006: stock2 should actually show some stocks data (Closed)

Created:
5 years, 6 months ago by abarth-chromium
Modified:
5 years, 6 months ago
Reviewers:
eseidel
CC:
gregsimon, jackson_old, mojo-reviews_chromium.org, qsr+mojo_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

stock2 should actually show some stocks data We're having trouble shrinkwrapping text, so this CL sets an explicit size for the last sale and the change in price. R=eseidel@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/23ec75590f2f34ebf7414b59b14efbbfb41bd388

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -51 lines) Patch
M sky/examples/stocks2/lib/stock_row.dart View 2 chunks +27 lines, -51 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
abarth-chromium
5 years, 6 months ago (2015-06-04 23:18:09 UTC) #1
eseidel
lgtm
5 years, 6 months ago (2015-06-04 23:35:37 UTC) #2
abarth-chromium
5 years, 6 months ago (2015-06-04 23:36:00 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
23ec75590f2f34ebf7414b59b14efbbfb41bd388 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698