Source/devtools/front_end/console/ConsoleView.js - Issue 1164763004: DevTools: render category filters in a way that they don't clash.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/devtools/front_end/console/ConsoleView.js

Issue 1164763004: DevTools: render category filters in a way that they don't clash. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: for landing Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « Source/devtools/front_end/components/inspectorViewTabbedPane.css ('k') | Source/devtools/front_end/console/consoleView.css » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/devtools/front_end/console/ConsoleView.js

diff --git a/Source/devtools/front_end/console/ConsoleView.js b/Source/devtools/front_end/console/ConsoleView.js

index 9182315bfdfad0bc20a10ca4ad007352bc4fc3cb..9ad214d8cb57bf4baaed5bd93d61dcdc085c9bd1 100644

--- a/Source/devtools/front_end/console/ConsoleView.js

+++ b/Source/devtools/front_end/console/ConsoleView.js

@@ -1046,6 +1046,10 @@ WebInspector.ConsoleViewFilter.prototype = {

this._textFilterUI.addEventListener(WebInspector.FilterUI.Events.FilterChanged, this._textFilterChanged, this);

filterBar.addFilter(this._textFilterUI);

+ this._hideNetworkMessagesCheckbox = new WebInspector.CheckboxFilterUI("hide-network-messages", WebInspector.UIString("Hide network messages"), true, WebInspector.moduleSetting("hideNetworkMessages"));

+ this._hideNetworkMessagesCheckbox.addEventListener(WebInspector.FilterUI.Events.FilterChanged, this._filterChanged.bind(this), this);

+ filterBar.addFilter(this._hideNetworkMessagesCheckbox);

var levels = [

{name: WebInspector.ConsoleMessage.MessageLevel.Error, label: WebInspector.UIString("Errors")},

{name: WebInspector.ConsoleMessage.MessageLevel.Warning, label: WebInspector.UIString("Warnings")},

@@ -1057,9 +1061,6 @@ WebInspector.ConsoleViewFilter.prototype = {

this._levelFilterUI = new WebInspector.NamedBitSetFilterUI(levels, this._messageLevelFiltersSetting);

this._levelFilterUI.addEventListener(WebInspector.FilterUI.Events.FilterChanged, this._filterChanged, this);

filterBar.addFilter(this._levelFilterUI);

- this._hideNetworkMessagesCheckbox = new WebInspector.CheckboxFilterUI("hide-network-messages", WebInspector.UIString("Hide network messages"), true, WebInspector.moduleSetting("hideNetworkMessages"));

- this._hideNetworkMessagesCheckbox.addEventListener(WebInspector.FilterUI.Events.FilterChanged, this._filterChanged.bind(this), this);

- filterBar.addFilter(this._hideNetworkMessagesCheckbox);

_textFilterChanged: function(event)

@@ -1150,7 +1151,7 @@ WebInspector.ConsoleViewFilter.prototype = {

this._messageURLFiltersSetting.set(this._messageURLFilters);

this._messageLevelFiltersSetting.set({});

this._view._showAllMessagesCheckbox.inputElement.checked = true;

- this._hideNetworkMessagesCheckbox.setState(false);

+ WebInspector.moduleSetting("hideNetworkMessages").set(false);

this._textFilterUI.setValue("");

this._filterChanged();