Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1167)

Side by Side Diff: Source/devtools/front_end/timeline/TimelinePanel.js

Issue 1164763004: DevTools: render category filters in a way that they don't clash. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: for landing Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2012 Google Inc. All rights reserved. 2 * Copyright (C) 2012 Google Inc. All rights reserved.
3 * Copyright (C) 2012 Intel Inc. All rights reserved. 3 * Copyright (C) 2012 Intel Inc. All rights reserved.
4 * 4 *
5 * Redistribution and use in source and binary forms, with or without 5 * Redistribution and use in source and binary forms, with or without
6 * modification, are permitted provided that the following conditions are 6 * modification, are permitted provided that the following conditions are
7 * met: 7 * met:
8 * 8 *
9 * * Redistributions of source code must retain the above copyright 9 * * Redistributions of source code must retain the above copyright
10 * notice, this list of conditions and the following disclaimer. 10 * notice, this list of conditions and the following disclaimer.
(...skipping 396 matching lines...) Expand 10 before | Expand all | Expand 10 after
407 this._filters._durationFilterUI.addEventListener(WebInspector.FilterUI.E vents.FilterChanged, this._durationFilterChanged, this); 407 this._filters._durationFilterUI.addEventListener(WebInspector.FilterUI.E vents.FilterChanged, this._durationFilterChanged, this);
408 this._filterBar.addFilter(this._filters._durationFilterUI); 408 this._filterBar.addFilter(this._filters._durationFilterUI);
409 409
410 this._filters._categoryFiltersUI = {}; 410 this._filters._categoryFiltersUI = {};
411 var categories = WebInspector.TimelineUIUtils.categories(); 411 var categories = WebInspector.TimelineUIUtils.categories();
412 for (var categoryName in categories) { 412 for (var categoryName in categories) {
413 var category = categories[categoryName]; 413 var category = categories[categoryName];
414 if (!category.visible) 414 if (!category.visible)
415 continue; 415 continue;
416 var filter = new WebInspector.CheckboxFilterUI(category.name, catego ry.title); 416 var filter = new WebInspector.CheckboxFilterUI(category.name, catego ry.title);
417 filter.setColor(category.fillColorStop0, category.borderColor);
417 this._filters._categoryFiltersUI[category.name] = filter; 418 this._filters._categoryFiltersUI[category.name] = filter;
418 filter.addEventListener(WebInspector.FilterUI.Events.FilterChanged, this._categoriesFilterChanged.bind(this, categoryName), this); 419 filter.addEventListener(WebInspector.FilterUI.Events.FilterChanged, this._categoriesFilterChanged.bind(this, categoryName), this);
419 this._filterBar.addFilter(filter); 420 this._filterBar.addFilter(filter);
420 } 421 }
421 return this._filterBar; 422 return this._filterBar;
422 }, 423 },
423 424
424 _textFilterChanged: function(event) 425 _textFilterChanged: function(event)
425 { 426 {
426 var searchQuery = this._filters._textFilterUI.value(); 427 var searchQuery = this._filters._textFilterUI.value();
(...skipping 1408 matching lines...) Expand 10 before | Expand all | Expand 10 after
1835 /** 1836 /**
1836 * @override 1837 * @override
1837 */ 1838 */
1838 reset: function() 1839 reset: function()
1839 { 1840 {
1840 this._filmStripView.reset(); 1841 this._filmStripView.reset();
1841 }, 1842 },
1842 1843
1843 __proto__: WebInspector.TimelineOverviewBase.prototype 1844 __proto__: WebInspector.TimelineOverviewBase.prototype
1844 } 1845 }
OLDNEW
« no previous file with comments | « Source/devtools/front_end/sources/sourcesPanel.css ('k') | Source/devtools/front_end/timeline/TimelineUIUtils.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698