Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(755)

Side by Side Diff: Source/devtools/front_end/network/NetworkLogView.js

Issue 1164763004: DevTools: render category filters in a way that they don't clash. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: for landing Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2007, 2008 Apple Inc. All rights reserved. 2 * Copyright (C) 2007, 2008 Apple Inc. All rights reserved.
3 * Copyright (C) 2008, 2009 Anthony Ricaud <rik@webkit.org> 3 * Copyright (C) 2008, 2009 Anthony Ricaud <rik@webkit.org>
4 * Copyright (C) 2011 Google Inc. All rights reserved. 4 * Copyright (C) 2011 Google Inc. All rights reserved.
5 * 5 *
6 * Redistribution and use in source and binary forms, with or without 6 * Redistribution and use in source and binary forms, with or without
7 * modification, are permitted provided that the following conditions 7 * modification, are permitted provided that the following conditions
8 * are met: 8 * are met:
9 * 9 *
10 * 1. Redistributions of source code must retain the above copyright 10 * 1. Redistributions of source code must retain the above copyright
(...skipping 227 matching lines...) Expand 10 before | Expand all | Expand 10 after
238 if (this._dataGrid.selectedNode) 238 if (this._dataGrid.selectedNode)
239 this._dataGrid.selectedNode.deselect(); 239 this._dataGrid.selectedNode.deselect();
240 }, 240 },
241 241
242 _addFilters: function() 242 _addFilters: function()
243 { 243 {
244 this._textFilterUI = new WebInspector.TextFilterUI(); 244 this._textFilterUI = new WebInspector.TextFilterUI();
245 this._textFilterUI.addEventListener(WebInspector.FilterUI.Events.FilterC hanged, this._filterChanged, this); 245 this._textFilterUI.addEventListener(WebInspector.FilterUI.Events.FilterC hanged, this._filterChanged, this);
246 this._filterBar.addFilter(this._textFilterUI); 246 this._filterBar.addFilter(this._textFilterUI);
247 247
248 var dataURLSetting = this._networkHideDataURLSetting;
249 this._dataURLFilterUI = new WebInspector.CheckboxFilterUI("hide-data-url ", WebInspector.UIString("Hide data URLs"), true, dataURLSetting);
250 this._dataURLFilterUI.addEventListener(WebInspector.FilterUI.Events.Filt erChanged, this._filterChanged.bind(this), this);
251 this._filterBar.addFilter(this._dataURLFilterUI);
252
248 var types = []; 253 var types = [];
249 for (var typeId in WebInspector.resourceTypes) { 254 for (var typeId in WebInspector.resourceTypes) {
250 var resourceType = WebInspector.resourceTypes[typeId]; 255 var resourceType = WebInspector.resourceTypes[typeId];
251 if (resourceType === WebInspector.resourceTypes.TextTrack) 256 if (resourceType === WebInspector.resourceTypes.TextTrack)
252 continue; 257 continue;
253 types.push({name: resourceType.name(), label: resourceType.categoryT itle()}); 258 types.push({name: resourceType.name(), label: resourceType.shortCate goryTitle(), title: resourceType.categoryTitle()});
254 } 259 }
255 this._resourceTypeFilterUI = new WebInspector.NamedBitSetFilterUI(types, this._networkResourceTypeFiltersSetting); 260 this._resourceTypeFilterUI = new WebInspector.NamedBitSetFilterUI(types, this._networkResourceTypeFiltersSetting);
256 this._resourceTypeFilterUI.addEventListener(WebInspector.FilterUI.Events .FilterChanged, this._filterChanged.bind(this), this); 261 this._resourceTypeFilterUI.addEventListener(WebInspector.FilterUI.Events .FilterChanged, this._filterChanged.bind(this), this);
257 this._filterBar.addFilter(this._resourceTypeFilterUI); 262 this._filterBar.addFilter(this._resourceTypeFilterUI);
258
259 var dataURLSetting = this._networkHideDataURLSetting;
260 this._dataURLFilterUI = new WebInspector.CheckboxFilterUI("hide-data-url ", WebInspector.UIString("Hide data URLs"), true, dataURLSetting);
261 this._dataURLFilterUI.addEventListener(WebInspector.FilterUI.Events.Filt erChanged, this._filterChanged.bind(this), this);
262 this._filterBar.addFilter(this._dataURLFilterUI);
263 }, 263 },
264 264
265 _resetSuggestionBuilder: function() 265 _resetSuggestionBuilder: function()
266 { 266 {
267 this._suggestionBuilder = new WebInspector.FilterSuggestionBuilder(WebIn spector.NetworkLogView._searchKeys); 267 this._suggestionBuilder = new WebInspector.FilterSuggestionBuilder(WebIn spector.NetworkLogView._searchKeys);
268 this._suggestionBuilder.addItem(WebInspector.NetworkLogView.FilterType.I s, WebInspector.NetworkLogView.IsFilterType.Running); 268 this._suggestionBuilder.addItem(WebInspector.NetworkLogView.FilterType.I s, WebInspector.NetworkLogView.IsFilterType.Running);
269 this._suggestionBuilder.addItem(WebInspector.NetworkLogView.FilterType.L argerThan, "100"); 269 this._suggestionBuilder.addItem(WebInspector.NetworkLogView.FilterType.L argerThan, "100");
270 this._suggestionBuilder.addItem(WebInspector.NetworkLogView.FilterType.L argerThan, "10k"); 270 this._suggestionBuilder.addItem(WebInspector.NetworkLogView.FilterType.L argerThan, "10k");
271 this._suggestionBuilder.addItem(WebInspector.NetworkLogView.FilterType.L argerThan, "1M"); 271 this._suggestionBuilder.addItem(WebInspector.NetworkLogView.FilterType.L argerThan, "1M");
272 this._textFilterUI.setSuggestionBuilder(this._suggestionBuilder); 272 this._textFilterUI.setSuggestionBuilder(this._suggestionBuilder);
(...skipping 1754 matching lines...) Expand 10 before | Expand all | Expand 10 after
2027 if (request.endTime !== -1 && request.endTime < windowStart) 2027 if (request.endTime !== -1 && request.endTime < windowStart)
2028 return false; 2028 return false;
2029 return true; 2029 return true;
2030 } 2030 }
2031 2031
2032 WebInspector.NetworkLogView.EventTypes = { 2032 WebInspector.NetworkLogView.EventTypes = {
2033 RequestSelected: "RequestSelected", 2033 RequestSelected: "RequestSelected",
2034 SearchCountUpdated: "SearchCountUpdated", 2034 SearchCountUpdated: "SearchCountUpdated",
2035 SearchIndexUpdated: "SearchIndexUpdated" 2035 SearchIndexUpdated: "SearchIndexUpdated"
2036 }; 2036 };
OLDNEW
« no previous file with comments | « Source/devtools/front_end/inspectorStyle.css ('k') | Source/devtools/front_end/network/networkPanel.css » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698