DevTools: render category filters in a way that they don't clash.

DevTools: render category filters in a way that they don't clash.

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=196506

[pfeldman, 2015-06-03 14:35:29]

pfeldman@chromium.org changed reviewers:
+ dgozman@chromium.org

[dgozman, 2015-06-03 15:14:31]

lgtm

https://codereview.chromium.org/1164763004/diff/1/Source/devtools/front_end/c...
File Source/devtools/front_end/common/ResourceType.js (right):

https://codereview.chromium.org/1164763004/diff/1/Source/devtools/front_end/c...
Source/devtools/front_end/common/ResourceType.js:129: Stylesheet: new
WebInspector.ResourceType("stylesheet", "Stylesheets", "Stylesheets", "CSS",
"rgb(157,231,119)", true),
Second parameter should be singular.

https://codereview.chromium.org/1164763004/diff/1/Source/devtools/front_end/u...
File Source/devtools/front_end/ui/filter.css (right):

https://codereview.chromium.org/1164763004/diff/1/Source/devtools/front_end/u...
Source/devtools/front_end/ui/filter.css:59: .filter-bitset-filter li {
Merge into rule below.

https://codereview.chromium.org/1164763004/diff/1/Source/devtools/front_end/u...
Source/devtools/front_end/ui/filter.css:114: flex: none;
Looks unnecessary.

[pfeldman, 2015-06-03 15:42:31]

The CQ bit was checked by pfeldman@chromium.org

[pfeldman, 2015-06-03 15:42:44]

The CQ bit was unchecked by pfeldman@chromium.org

[pfeldman, 2015-06-04 10:42:27]

The CQ bit was checked by pfeldman@chromium.org

[pfeldman, 2015-06-04 10:42:27]

The patchset sent to the CQ was uploaded after l-g-t-m from dgozman@chromium.org
Link to the patchset: https://codereview.chromium.org/1164763004/#ps40001
(title: "for landing")

[commit-bot: I haz the power, 2015-06-04 10:42:36]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1164763004/40001

[commit-bot: I haz the power, 2015-06-04 12:08:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-06-04 12:08:36]

Try jobs failed on following builders:
  linux_blink_rel on tryserver.blink (JOB_FAILED,
http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/6...)

[pfeldman, 2015-06-04 12:33:30]

The CQ bit was checked by pfeldman@chromium.org

[pfeldman, 2015-06-04 12:33:30]

The patchset sent to the CQ was uploaded after l-g-t-m from dgozman@chromium.org
Link to the patchset: https://codereview.chromium.org/1164763004/#ps60001
(title: "fixed tests")

[commit-bot: I haz the power, 2015-06-04 12:33:39]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1164763004/60001

[pfeldman, 2015-06-04 13:01:47]

The CQ bit was checked by pfeldman@chromium.org

[pfeldman, 2015-06-04 13:01:47]

The patchset sent to the CQ was uploaded after l-g-t-m from dgozman@chromium.org
Link to the patchset: https://codereview.chromium.org/1164763004/#ps80001
(title: "for landing")

[commit-bot: I haz the power, 2015-06-04 13:02:04]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1164763004/80001

[commit-bot: I haz the power, 2015-06-04 14:07:47]

Committed patchset #5 (id:80001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=196506

[leviw_travelin_and_unemployed, 2015-06-04 18:42:55]

leviw@chromium.org changed reviewers:
+ leviw@chromium.org

[leviw_travelin_and_unemployed, 2015-06-04 18:42:57]

This is triggering failures on inspector/extensions/extensions-audits.html.

It seems innocuous enough that I'm going to set it as failing and assign you the
bug instead of reverting this patch.

[pfeldman, 2015-06-05 13:41:23]

Thank you Levi, you did the right thing, much appreciated!