Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(17)

Issue 1164763004: DevTools: render category filters in a way that they don't clash. (Closed)

Created:
4 years, 11 months ago by pfeldman
Modified:
4 years, 11 months ago
CC:
apavlov+blink_chromium.org, blink-reviews, caseq+blink_chromium.org, devtools-reviews_chromium.org, kozyatinskiy+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, sergeyv+blink_chromium.org, yurys+blink_chromium.org
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

DevTools: render category filters in a way that they don't clash. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=196506

Patch Set 1 #

Total comments: 3

Patch Set 2 : for landing #

Patch Set 3 : for landing #

Patch Set 4 : fixed tests #

Patch Set 5 : for landing #

Unified diffs Side-by-side diffs Delta from patch set Stats (+185 lines, -169 lines) Patch
M LayoutTests/http/tests/inspector/resource-tree/resource-tree-frame-add-expected.txt View 1 2 3 2 chunks +6 lines, -6 lines 0 comments Download
M LayoutTests/http/tests/inspector/resource-tree/resource-tree-frame-navigate-expected.txt View 1 2 3 2 chunks +8 lines, -8 lines 0 comments Download
M LayoutTests/http/tests/inspector/resource-tree/resource-tree-htmlimports-expected.txt View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/inspector/resource-tree/resource-tree-non-unique-url-expected.txt View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/http/tests/inspector/resource-tree/resource-tree-reload-expected.txt View 1 2 3 1 chunk +4 lines, -4 lines 0 comments Download
M LayoutTests/inspector/extensions/extensions-audits-api-expected.txt View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download
M LayoutTests/inspector/extensions/extensions-audits-content-script-expected.txt View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download
M Source/devtools/front_end/common/ResourceType.js View 1 3 chunks +21 lines, -11 lines 0 comments Download
M Source/devtools/front_end/components/InspectorView.js View 1 1 chunk +3 lines, -1 line 0 comments Download
M Source/devtools/front_end/components/inspectorViewTabbedPane.css View 1 2 chunks +2 lines, -2 lines 0 comments Download
M Source/devtools/front_end/console/ConsoleView.js View 1 2 3 4 3 chunks +5 lines, -4 lines 0 comments Download
M Source/devtools/front_end/console/consoleView.css View 1 2 1 chunk +1 line, -1 line 0 comments Download
M Source/devtools/front_end/elements/StylesSidebarPane.js View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M Source/devtools/front_end/elements/elementsPanel.css View 1 2 2 chunks +4 lines, -4 lines 0 comments Download
M Source/devtools/front_end/inspectorStyle.css View 1 2 1 chunk +6 lines, -2 lines 0 comments Download
M Source/devtools/front_end/network/NetworkLogView.js View 1 chunk +6 lines, -6 lines 0 comments Download
M Source/devtools/front_end/network/networkPanel.css View 1 chunk +0 lines, -10 lines 0 comments Download
M Source/devtools/front_end/sidebarPane.css View 1 2 1 chunk +0 lines, -2 lines 0 comments Download
M Source/devtools/front_end/sources/sourcesPanel.css View 1 1 chunk +2 lines, -1 line 0 comments Download
M Source/devtools/front_end/timeline/TimelinePanel.js View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M Source/devtools/front_end/timeline/TimelineUIUtils.js View 1 chunk +0 lines, -1 line 0 comments Download
M Source/devtools/front_end/timeline/timelinePanel.css View 1 2 1 chunk +1 line, -1 line 0 comments Download
M Source/devtools/front_end/ui/FilterBar.js View 1 2 7 chunks +28 lines, -62 lines 0 comments Download
M Source/devtools/front_end/ui/SearchableView.js View 1 1 chunk +2 lines, -1 line 0 comments Download
M Source/devtools/front_end/ui/UIUtils.js View 1 2 1 chunk +37 lines, -3 lines 0 comments Download
M Source/devtools/front_end/ui/checkboxTextLabel.css View 1 2 1 chunk +11 lines, -4 lines 0 comments Download
M Source/devtools/front_end/ui/filter.css View 1 2 5 chunks +19 lines, -26 lines 0 comments Download
M Source/devtools/front_end/ui/splitWidget.css View 1 2 3 chunks +4 lines, -4 lines 0 comments Download
M Source/devtools/front_end/ui/toolbar.css View 1 2 2 chunks +5 lines, -1 line 0 comments Download

Messages

Total messages: 20 (11 generated)
pfeldman
4 years, 11 months ago (2015-06-03 14:35:30 UTC) #2
dgozman
lgtm https://codereview.chromium.org/1164763004/diff/1/Source/devtools/front_end/common/ResourceType.js File Source/devtools/front_end/common/ResourceType.js (right): https://codereview.chromium.org/1164763004/diff/1/Source/devtools/front_end/common/ResourceType.js#newcode129 Source/devtools/front_end/common/ResourceType.js:129: Stylesheet: new WebInspector.ResourceType("stylesheet", "Stylesheets", "Stylesheets", "CSS", "rgb(157,231,119)", true), ...
4 years, 11 months ago (2015-06-03 15:14:31 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1164763004/40001
4 years, 11 months ago (2015-06-04 10:42:36 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: linux_blink_rel on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/65015)
4 years, 11 months ago (2015-06-04 12:08:36 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1164763004/60001
4 years, 11 months ago (2015-06-04 12:33:39 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1164763004/80001
4 years, 11 months ago (2015-06-04 13:02:04 UTC) #16
commit-bot: I haz the power
Committed patchset #5 (id:80001) as https://src.chromium.org/viewvc/blink?view=rev&revision=196506
4 years, 11 months ago (2015-06-04 14:07:47 UTC) #17
leviw_travelin_and_unemployed
This is triggering failures on inspector/extensions/extensions-audits.html. It seems innocuous enough that I'm going to set ...
4 years, 11 months ago (2015-06-04 18:42:57 UTC) #19
pfeldman
4 years, 11 months ago (2015-06-05 13:41:23 UTC) #20
Message was sent while issue was closed.
Thank you Levi, you did the right thing, much appreciated!

Powered by Google App Engine
This is Rietveld 408576698