Tidy up CompositorWorkerManager unit tests.

Source/modules/serviceworkers/ServiceWorkerGlobalScopeClient.cpp

 /*
  * Copyright (C) 2014 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 25 matching lines @@
 
 namespace blink {
 
 const char* ServiceWorkerGlobalScopeClient::supplementName()
 {
     return "ServiceWorkerGlobalScopeClient";
 }
 
 ServiceWorkerGlobalScopeClient* ServiceWorkerGlobalScopeClient::from(ExecutionContext* context)
 {
-    return static_cast<ServiceWorkerGlobalScopeClient*>(WillBeHeapSupplement<WorkerClients>::from(toWorkerGlobalScope(context)->clients(), supplementName()));
+    ASSERT(context->isWorkerGlobalScope());

[haraken, 2015/06/07 23:37:11]

You can remove this. This check is already done in toWorkerGlobalScope(context).

[sof, 2015/06/08 08:18:16]

Removed (here&elsewhere.)

+    WorkerClients* clients = toWorkerGlobalScope(context)->clients();
+    ASSERT(clients);

[kinuko, 2015/06/08 04:36:59]

Should these rather return nullptr here if we allow null-clients, or could we
add an assertion like ASSERT(m_workerClients || isCompositorWorkerGlobalScope())
(with a comment to note that CW doesn't expose APIs that require clients impl)
in WorkerGlobalScope's ctor so that intention (for allowing null clients)
becomes clearer?

[sof, 2015/06/08 08:18:16]

But ServiceWorkerGlobalScopeClient isn't exposed to CompositorWorker?

(Unit test uses of workers will also supply a null WorkerClients.)

+    return static_cast<ServiceWorkerGlobalScopeClient*>(WillBeHeapSupplement<WorkerClients>::from(clients, supplementName()));
 }
 
 void provideServiceWorkerGlobalScopeClientToWorker(WorkerClients* clients, PassOwnPtrWillBeRawPtr<ServiceWorkerGlobalScopeClient> client)
 {
     clients->provideSupplement(ServiceWorkerGlobalScopeClient::supplementName(), client);
 }
 
 } // namespace blink