Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(457)

Unified Diff: Source/core/frame/FrameView.cpp

Issue 1164713010: Invalidate non-composited subtree on needsPaintInvalidationLayer (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Update expectations Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/frame/FrameView.cpp
diff --git a/Source/core/frame/FrameView.cpp b/Source/core/frame/FrameView.cpp
index 04c1c28aa2015b31187252cfe1648fa47d30b9f4..19bfd555f4cc5e0ba3a61be3171147485f9590a8 100644
--- a/Source/core/frame/FrameView.cpp
+++ b/Source/core/frame/FrameView.cpp
@@ -1319,20 +1319,6 @@ void FrameView::scrollContentsIfNeededRecursive()
}
}
-// FIXME: If we had a flag to force invalidations in a whole subtree, we could get rid of this function (crbug.com/410097).
-static void setShouldDoFullPaintInvalidationIncludingNonCompositingDescendants(const DeprecatedPaintLayer* layer)
-{
- layer->layoutObject()->setShouldDoFullPaintInvalidation();
-
- for (DeprecatedPaintLayer* child = layer->firstChild(); child; child = child->nextSibling()) {
- // Don't include paint invalidation rects for composited child layers; they will paint themselves and have a different origin.
- if (child->isPaintInvalidationContainer())
- continue;
-
- setShouldDoFullPaintInvalidationIncludingNonCompositingDescendants(child);
- }
-}
-
bool FrameView::invalidateViewportConstrainedObjects()
{
for (const auto& viewportConstrainedObject : *m_viewportConstrainedObjects) {
@@ -1359,7 +1345,7 @@ bool FrameView::invalidateViewportConstrainedObjects()
"data",
InspectorScrollInvalidationTrackingEvent::data(*layoutObject));
- setShouldDoFullPaintInvalidationIncludingNonCompositingDescendants(layer);
+ layoutObject->setShouldDoFullPaintInvalidationIncludingNonCompositingDescendants();
}
return true;
}
@@ -1392,7 +1378,7 @@ void FrameView::scrollContentsSlowPath(const IntRect& updateRect)
if (contentsInCompositedLayer())
layoutView()->layer()->compositedDeprecatedPaintLayerMapping()->setContentsNeedDisplay();
else
- setShouldDoFullPaintInvalidationIncludingNonCompositingDescendants(layoutView()->layer());
+ layoutView()->setShouldDoFullPaintInvalidationIncludingNonCompositingDescendants();
}
if (contentsInCompositedLayer()) {
« no previous file with comments | « LayoutTests/fast/repaint/add-transform-repaint-descendants-expected.html ('k') | Source/core/layout/LayoutObject.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698