Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Unified Diff: components/data_reduction_proxy/core/browser/data_reduction_proxy_config_unittest.cc

Issue 1164713004: Store network quality samples so we can compute percentiles. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Changes to make the tests work on Windows Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/data_reduction_proxy/core/browser/data_reduction_proxy_config_unittest.cc
diff --git a/components/data_reduction_proxy/core/browser/data_reduction_proxy_config_unittest.cc b/components/data_reduction_proxy/core/browser/data_reduction_proxy_config_unittest.cc
index 26f726dff3bcb095f62e75950aa01bfc068663cb..a88230bd79ec5d6f91ad3c17a821a98598719682 100644
--- a/components/data_reduction_proxy/core/browser/data_reduction_proxy_config_unittest.cc
+++ b/components/data_reduction_proxy/core/browser/data_reduction_proxy_config_unittest.cc
@@ -1216,15 +1216,16 @@ TEST_F(DataReductionProxyConfigTest, LoFiStatusTransition) {
}
}
-// Overrides net::NetworkQualityEstimator::GetEstimate() for testing purposes.
+// Overrides net::NetworkQualityEstimator::GetPeakEstimate() for testing
+// purposes.
class TestNetworkQualityEstimator : public net::NetworkQualityEstimator {
public:
TestNetworkQualityEstimator() : rtt_(base::TimeDelta()), kbps_(0) {}
~TestNetworkQualityEstimator() override {}
- net::NetworkQuality GetEstimate() const override {
- return net::NetworkQuality(rtt_, 0.0, kbps_, 0.0);
+ net::NetworkQuality GetPeakEstimate() const override {
+ return net::NetworkQuality(rtt_, kbps_);
}
void SetRtt(base::TimeDelta rtt) { rtt_ = rtt; }
@@ -1268,7 +1269,7 @@ TEST_F(DataReductionProxyConfigTest, AutoLoFiParams) {
EXPECT_EQ(base::TimeDelta::FromMilliseconds(rtt_msec),
config.auto_lofi_minimum_rtt_);
- EXPECT_EQ(240U, config.auto_lofi_maximum_kbps_);
+ EXPECT_EQ(240, config.auto_lofi_maximum_kbps_);
EXPECT_EQ(base::TimeDelta::FromSeconds(hysteresis_sec),
config.auto_lofi_hysteresis_);
« no previous file with comments | « components/data_reduction_proxy/core/browser/data_reduction_proxy_config.cc ('k') | net/base/network_quality.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698