Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(931)

Unified Diff: net/url_request/url_request_unittest.cc

Issue 1164713004: Store network quality samples so we can compute percentiles. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressed comments. Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/url_request/url_request_unittest.cc
diff --git a/net/url_request/url_request_unittest.cc b/net/url_request/url_request_unittest.cc
index 158618fd8b4129730ad4ca3f30357abee16dc341..11b55824f27cc08611b6bc6fc631fcbcf707cd77 100644
--- a/net/url_request/url_request_unittest.cc
+++ b/net/url_request/url_request_unittest.cc
@@ -4102,12 +4102,10 @@ TEST_F(URLRequestTestHTTP, NetworkQualityEstimator) {
base::RunLoop().Run();
NetworkQuality network_quality =
- context.network_quality_estimator()->GetEstimate();
- EXPECT_GE(network_quality.fastest_rtt,
+ context.network_quality_estimator()->GetPeakEstimate();
+ EXPECT_GE(network_quality.rtt(),
base::TimeDelta::FromMilliseconds(sleep_duration_milliseconds));
- EXPECT_GT(network_quality.fastest_rtt_confidence, 0);
- EXPECT_GT(network_quality.peak_throughput_kbps, uint64_t(0));
- EXPECT_GT(network_quality.peak_throughput_kbps_confidence, 0);
+ EXPECT_GT(network_quality.downstream_throughput_kbps(), 0);
// Verify that histograms are not populated. They should populate only when
// there is a change in ConnectionType.
« net/base/network_quality_estimator_unittest.cc ('K') | « net/url_request/url_request_job.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698