Revert "Linux: add library loader for GNOME keyring."

chrome/browser/password_manager/native_backend_gnome_x_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <stdarg.h>
 
 #include "base/basictypes.h"
 #include "base/stl_util.h"
 #include "base/string_util.h"
 #include "base/stringprintf.h"
@@ skipping 239 matching lines @@
     element = g_list_next(element);
   }
   g_list_free(results);
   return NULL;
 }
 
 const gchar* mock_gnome_keyring_result_to_message(GnomeKeyringResult res) {
   return "mock keyring simulating failure";
 }
 
-}  // namespace
+// Inherit to get access to protected fields.
+class MockGnomeKeyringLoader : public GnomeKeyringLoader {
+ public:
+  static bool LoadMockGnomeKeyring() {
+#define GNOME_KEYRING_ASSIGN_POINTER(name) \
+  gnome_keyring_##name = &mock_gnome_keyring_##name;
+    GNOME_KEYRING_FOR_EACH_FUNC(GNOME_KEYRING_ASSIGN_POINTER)
+#undef GNOME_KEYRING_ASSIGN_POINTER
+    keyring_loaded = true;
+    // Reset the state of the mock library.
+    mock_keyring_items.clear();
+    mock_keyring_reject_local_ids = false;
+    return true;
+  }
+};
+
+}  // anonymous namespace
 
 class NativeBackendGnomeTest : public testing::Test {
  protected:
   NativeBackendGnomeTest()
       : ui_thread_(BrowserThread::UI, &message_loop_),
         db_thread_(BrowserThread::DB) {
   }
 
   virtual void SetUp() {
     ASSERT_TRUE(db_thread_.Start());
 
+    MockGnomeKeyringLoader::LoadMockGnomeKeyring();
+
     form_google_.origin = GURL("http://www.google.com/");
     form_google_.action = GURL("http://www.google.com/login");
     form_google_.username_element = UTF8ToUTF16("user");
     form_google_.username_value = UTF8ToUTF16("joeschmoe");
     form_google_.password_element = UTF8ToUTF16("pass");
     form_google_.password_value = UTF8ToUTF16("seekrit");
     form_google_.submit_element = UTF8ToUTF16("submit");
     form_google_.signon_realm = "Google";
 
     form_isc_.origin = GURL("http://www.isc.org/");
     form_isc_.action = GURL("http://www.isc.org/auth");
     form_isc_.username_element = UTF8ToUTF16("id");
     form_isc_.username_value = UTF8ToUTF16("janedoe");
     form_isc_.password_element = UTF8ToUTF16("passwd");
     form_isc_.password_value = UTF8ToUTF16("ihazabukkit");
     form_isc_.submit_element = UTF8ToUTF16("login");
     form_isc_.signon_realm = "ISC";
   }
 
   virtual void TearDown() {
     MessageLoop::current()->PostTask(FROM_HERE, MessageLoop::QuitClosure());
     MessageLoop::current()->Run();
     db_thread_.Stop();
   }
 
-  static void SetUpMockKeyring(NativeBackendGnome* backend) {
-    LibGnomeKeyringLoader* loader = backend->libgnome_keyring_loader();
-    loader->gnome_keyring_is_available = &mock_gnome_keyring_is_available;
-    loader->gnome_keyring_store_password = &mock_gnome_keyring_store_password;
-    loader->gnome_keyring_delete_password = &mock_gnome_keyring_delete_password;
-    loader->gnome_keyring_find_itemsv = &mock_gnome_keyring_find_itemsv;
-    loader->gnome_keyring_result_to_message =
-        &mock_gnome_keyring_result_to_message;
-
-    // Reset the state of the mock library.
-    mock_keyring_items.clear();
-    mock_keyring_reject_local_ids = false;
-  }
-
   void RunBothThreads() {
     // First we post a message to the DB thread that will run after all other
     // messages that have been posted to the DB thread (we don't expect more
     // to be posted), which posts a message to the UI thread to quit the loop.
     // That way we can run both loops and be sure that the UI thread loop will
     // quit so we can get on with the rest of the test.
     BrowserThread::PostTask(BrowserThread::DB, FROM_HERE,
         base::Bind(&PostQuitTask, &message_loop_));
     MessageLoop::current()->Run();
   }
@@ skipping 63 matching lines @@
   PasswordForm form_google_;
   PasswordForm form_isc_;
 };
 
 TEST_F(NativeBackendGnomeTest, BasicAddLogin) {
   // Pretend that the migration has already taken place.
   profile_.GetPrefs()->SetBoolean(prefs::kPasswordsUseLocalProfileId, true);
 
   NativeBackendGnome backend(42, profile_.GetPrefs());
   backend.Init();
-  SetUpMockKeyring(&backend);
 
   BrowserThread::PostTask(
       BrowserThread::DB, FROM_HERE,
       base::Bind(base::IgnoreResult(&NativeBackendGnome::AddLogin),
                  base::Unretained(&backend), form_google_));
 
   RunBothThreads();
 
   EXPECT_EQ(1u, mock_keyring_items.size());
   if (mock_keyring_items.size() > 0)
     CheckMockKeyringItem(&mock_keyring_items[0], form_google_, "chrome-42");
 }
 
 TEST_F(NativeBackendGnomeTest, BasicListLogins) {
   // Pretend that the migration has already taken place.
   profile_.GetPrefs()->SetBoolean(prefs::kPasswordsUseLocalProfileId, true);
 
   NativeBackendGnome backend(42, profile_.GetPrefs());
   backend.Init();
-  SetUpMockKeyring(&backend);
 
   BrowserThread::PostTask(
       BrowserThread::DB, FROM_HERE,
       base::Bind(base::IgnoreResult( &NativeBackendGnome::AddLogin),
                  base::Unretained(&backend), form_google_));
 
   std::vector<PasswordForm*> form_list;
   BrowserThread::PostTask(
       BrowserThread::DB, FROM_HERE,
       base::Bind(
@@ skipping 10 matching lines @@
   if (mock_keyring_items.size() > 0)
     CheckMockKeyringItem(&mock_keyring_items[0], form_google_, "chrome-42");
 }
 
 TEST_F(NativeBackendGnomeTest, BasicRemoveLogin) {
   // Pretend that the migration has already taken place.
   profile_.GetPrefs()->SetBoolean(prefs::kPasswordsUseLocalProfileId, true);
 
   NativeBackendGnome backend(42, profile_.GetPrefs());
   backend.Init();
-  SetUpMockKeyring(&backend);
 
   BrowserThread::PostTask(
       BrowserThread::DB, FROM_HERE,
       base::Bind(base::IgnoreResult(&NativeBackendGnome::AddLogin),
                  base::Unretained(&backend), form_google_));
 
   RunBothThreads();
 
   EXPECT_EQ(1u, mock_keyring_items.size());
   if (mock_keyring_items.size() > 0)
     CheckMockKeyringItem(&mock_keyring_items[0], form_google_, "chrome-42");
 
   BrowserThread::PostTask(
       BrowserThread::DB, FROM_HERE,
       base::Bind(base::IgnoreResult(&NativeBackendGnome::RemoveLogin),
                  base::Unretained(&backend), form_google_));
 
   RunBothThreads();
 
   EXPECT_EQ(0u, mock_keyring_items.size());
 }
 
 TEST_F(NativeBackendGnomeTest, RemoveNonexistentLogin) {
   // Pretend that the migration has already taken place.
   profile_.GetPrefs()->SetBoolean(prefs::kPasswordsUseLocalProfileId, true);
 
   NativeBackendGnome backend(42, profile_.GetPrefs());
   backend.Init();
-  SetUpMockKeyring(&backend);
 
   // First add an unrelated login.
   BrowserThread::PostTask(
       BrowserThread::DB, FROM_HERE,
       base::Bind(base::IgnoreResult(&NativeBackendGnome::AddLogin),
                  base::Unretained(&backend), form_google_));
 
   RunBothThreads();
 
   EXPECT_EQ(1u, mock_keyring_items.size());
@@ skipping 24 matching lines @@
   if (mock_keyring_items.size() > 0)
     CheckMockKeyringItem(&mock_keyring_items[0], form_google_, "chrome-42");
 }
 
 TEST_F(NativeBackendGnomeTest, AddDuplicateLogin) {
   // Pretend that the migration has already taken place.
   profile_.GetPrefs()->SetBoolean(prefs::kPasswordsUseLocalProfileId, true);
 
   NativeBackendGnome backend(42, profile_.GetPrefs());
   backend.Init();
-  SetUpMockKeyring(&backend);
 
   BrowserThread::PostTask(
       BrowserThread::DB, FROM_HERE,
       base::Bind(base::IgnoreResult(&NativeBackendGnome::AddLogin),
                  base::Unretained(&backend), form_google_));
   BrowserThread::PostTask(
       BrowserThread::DB, FROM_HERE,
       base::Bind(base::IgnoreResult(&NativeBackendGnome::AddLogin),
                  base::Unretained(&backend), form_google_));
 
   RunBothThreads();
 
   EXPECT_EQ(1u, mock_keyring_items.size());
   if (mock_keyring_items.size() > 0)
     CheckMockKeyringItem(&mock_keyring_items[0], form_google_, "chrome-42");
 }
 
 TEST_F(NativeBackendGnomeTest, ListLoginsAppends) {
   // Pretend that the migration has already taken place.
   profile_.GetPrefs()->SetBoolean(prefs::kPasswordsUseLocalProfileId, true);
 
   NativeBackendGnome backend(42, profile_.GetPrefs());
   backend.Init();
-  SetUpMockKeyring(&backend);
 
   BrowserThread::PostTask(
       BrowserThread::DB, FROM_HERE,
       base::Bind(base::IgnoreResult(&NativeBackendGnome::AddLogin),
                  base::Unretained(&backend), form_google_));
 
   // Send the same request twice with the same list both times.
   std::vector<PasswordForm*> form_list;
   BrowserThread::PostTask(
       BrowserThread::DB, FROM_HERE,
@@ skipping 19 matching lines @@
 
 // TODO(mdm): add more basic (i.e. non-migration) tests here at some point.
 
 TEST_F(NativeBackendGnomeTest, DISABLED_MigrateOneLogin) {
   // Reject attempts to migrate so we can populate the store.
   mock_keyring_reject_local_ids = true;
 
   {
     NativeBackendGnome backend(42, profile_.GetPrefs());
     backend.Init();
-    SetUpMockKeyring(&backend);
 
     BrowserThread::PostTask(BrowserThread::DB, FROM_HERE,
         base::Bind(base::IgnoreResult(&NativeBackendGnome::AddLogin),
                    base::Unretained(&backend), form_google_));
 
     // Make sure we can get the form back even when migration is failing.
     std::vector<PasswordForm*> form_list;
     BrowserThread::PostTask(
         BrowserThread::DB, FROM_HERE,
         base::Bind(
@@ skipping 10 matching lines @@
   EXPECT_EQ(1u, mock_keyring_items.size());
   if (mock_keyring_items.size() > 0)
     CheckMockKeyringItem(&mock_keyring_items[0], form_google_, "chrome");
 
   // Now allow the migration.
   mock_keyring_reject_local_ids = false;
 
   {
     NativeBackendGnome backend(42, profile_.GetPrefs());
     backend.Init();
-    SetUpMockKeyring(&backend);
 
     // This should not trigger migration because there will be no results.
     std::vector<PasswordForm*> form_list;
     BrowserThread::PostTask(
         BrowserThread::DB, FROM_HERE,
         base::Bind(base::IgnoreResult(&NativeBackendGnome::GetBlacklistLogins),
                    base::Unretained(&backend), &form_list));
 
     RunBothThreads();
 
     // Check that we got nothing back.
     EXPECT_EQ(0u, form_list.size());
     STLDeleteElements(&form_list);
   }
 
   // Check that the keyring is unmodified.
   EXPECT_EQ(1u, mock_keyring_items.size());
   if (mock_keyring_items.size() > 0)
     CheckMockKeyringItem(&mock_keyring_items[0], form_google_, "chrome");
 
   // Check that we haven't set the persistent preference.
   EXPECT_FALSE(
       profile_.GetPrefs()->GetBoolean(prefs::kPasswordsUseLocalProfileId));
 
   {
     NativeBackendGnome backend(42, profile_.GetPrefs());
     backend.Init();
-    SetUpMockKeyring(&backend);
 
     // Trigger the migration by looking something up.
     std::vector<PasswordForm*> form_list;
     BrowserThread::PostTask(
         BrowserThread::DB, FROM_HERE,
         base::Bind(
             base::IgnoreResult(&NativeBackendGnome::GetAutofillableLogins),
             base::Unretained(&backend), &form_list));
 
     RunBothThreads();
@@ skipping 14 matching lines @@
       profile_.GetPrefs()->GetBoolean(prefs::kPasswordsUseLocalProfileId));
 }
 
 TEST_F(NativeBackendGnomeTest, DISABLED_MigrateToMultipleProfiles) {
   // Reject attempts to migrate so we can populate the store.
   mock_keyring_reject_local_ids = true;
 
   {
     NativeBackendGnome backend(42, profile_.GetPrefs());
     backend.Init();
-    SetUpMockKeyring(&backend);
 
     BrowserThread::PostTask(
         BrowserThread::DB, FROM_HERE,
         base::Bind(base::IgnoreResult(&NativeBackendGnome::AddLogin),
                    base::Unretained(&backend), form_google_));
 
     RunBothThreads();
   }
 
   EXPECT_EQ(1u, mock_keyring_items.size());
   if (mock_keyring_items.size() > 0)
     CheckMockKeyringItem(&mock_keyring_items[0], form_google_, "chrome");
 
   // Now allow the migration.
   mock_keyring_reject_local_ids = false;
 
   {
     NativeBackendGnome backend(42, profile_.GetPrefs());
     backend.Init();
-    SetUpMockKeyring(&backend);
 
     // Trigger the migration by looking something up.
     std::vector<PasswordForm*> form_list;
     BrowserThread::PostTask(
         BrowserThread::DB, FROM_HERE,
         base::Bind(
             base::IgnoreResult(&NativeBackendGnome::GetAutofillableLogins),
             base::Unretained(&backend), &form_list));
 
     RunBothThreads();
@@ skipping 13 matching lines @@
   EXPECT_TRUE(
       profile_.GetPrefs()->GetBoolean(prefs::kPasswordsUseLocalProfileId));
 
   // Normally we'd actually have a different profile. But in the test just reset
   // the profile's persistent pref; we pass in the local profile id anyway.
   profile_.GetPrefs()->SetBoolean(prefs::kPasswordsUseLocalProfileId, false);
 
   {
     NativeBackendGnome backend(24, profile_.GetPrefs());
     backend.Init();
-    SetUpMockKeyring(&backend);
 
     // Trigger the migration by looking something up.
     std::vector<PasswordForm*> form_list;
     BrowserThread::PostTask(
         BrowserThread::DB, FROM_HERE,
         base::Bind(
             base::IgnoreResult(&NativeBackendGnome::GetAutofillableLogins),
             base::Unretained(&backend), &form_list));
 
     RunBothThreads();
@@ skipping 12 matching lines @@
     CheckMockKeyringItem(&mock_keyring_items[2], form_google_, "chrome-24");
 }
 
 TEST_F(NativeBackendGnomeTest, DISABLED_NoMigrationWithPrefSet) {
   // Reject attempts to migrate so we can populate the store.
   mock_keyring_reject_local_ids = true;
 
   {
     NativeBackendGnome backend(42, profile_.GetPrefs());
     backend.Init();
-    SetUpMockKeyring(&backend);
 
     BrowserThread::PostTask(
         BrowserThread::DB, FROM_HERE,
         base::Bind(base::IgnoreResult(&NativeBackendGnome::AddLogin),
                    base::Unretained(&backend), form_google_));
 
     RunBothThreads();
   }
 
   EXPECT_EQ(1u, mock_keyring_items.size());
   if (mock_keyring_items.size() > 0)
     CheckMockKeyringItem(&mock_keyring_items[0], form_google_, "chrome");
 
   // Now allow migration, but also pretend that the it has already taken place.
   mock_keyring_reject_local_ids = false;
   profile_.GetPrefs()->SetBoolean(prefs::kPasswordsUseLocalProfileId, true);
 
   {
     NativeBackendGnome backend(42, profile_.GetPrefs());
     backend.Init();
-    SetUpMockKeyring(&backend);
 
     // Trigger the migration by adding a new login.
     BrowserThread::PostTask(
         BrowserThread::DB, FROM_HERE,
         base::Bind(base::IgnoreResult(&NativeBackendGnome::AddLogin),
                    base::Unretained(&backend), form_isc_));
 
     // Look up all logins; we expect only the one we added.
     std::vector<PasswordForm*> form_list;
     BrowserThread::PostTask(
@@ skipping 18 matching lines @@
     CheckMockKeyringItem(&mock_keyring_items[1], form_isc_, "chrome-42");
 }
 
 TEST_F(NativeBackendGnomeTest, DISABLED_DeleteMigratedPasswordIsIsolated) {
   // Reject attempts to migrate so we can populate the store.
   mock_keyring_reject_local_ids = true;
 
   {
     NativeBackendGnome backend(42, profile_.GetPrefs());
     backend.Init();
-    SetUpMockKeyring(&backend);
 
     BrowserThread::PostTask(
         BrowserThread::DB, FROM_HERE,
         base::Bind(base::IgnoreResult(&NativeBackendGnome::AddLogin),
                    base::Unretained(&backend), form_google_));
 
     RunBothThreads();
   }
 
   EXPECT_EQ(1u, mock_keyring_items.size());
   if (mock_keyring_items.size() > 0)
     CheckMockKeyringItem(&mock_keyring_items[0], form_google_, "chrome");
 
   // Now allow the migration.
   mock_keyring_reject_local_ids = false;
 
   {
     NativeBackendGnome backend(42, profile_.GetPrefs());
     backend.Init();
-    SetUpMockKeyring(&backend);
 
     // Trigger the migration by looking something up.
     std::vector<PasswordForm*> form_list;
     BrowserThread::PostTask(
         BrowserThread::DB, FROM_HERE,
         base::Bind(
             base::IgnoreResult(&NativeBackendGnome::GetAutofillableLogins),
             base::Unretained(&backend), &form_list));
 
     RunBothThreads();
@@ skipping 13 matching lines @@
   EXPECT_TRUE(
       profile_.GetPrefs()->GetBoolean(prefs::kPasswordsUseLocalProfileId));
 
   // Normally we'd actually have a different profile. But in the test just reset
   // the profile's persistent pref; we pass in the local profile id anyway.
   profile_.GetPrefs()->SetBoolean(prefs::kPasswordsUseLocalProfileId, false);
 
   {
     NativeBackendGnome backend(24, profile_.GetPrefs());
     backend.Init();
-    SetUpMockKeyring(&backend);
 
     // Trigger the migration by looking something up.
     std::vector<PasswordForm*> form_list;
     BrowserThread::PostTask(
         BrowserThread::DB, FROM_HERE,
         base::Bind(
             base::IgnoreResult(&NativeBackendGnome::GetAutofillableLogins),
             base::Unretained(&backend), &form_list));
 
     RunBothThreads();
@@ skipping 20 matching lines @@
     RunBothThreads();
 
     // The other two copies of the password in different profiles should remain.
     EXPECT_EQ(2u, mock_keyring_items.size());
     if (mock_keyring_items.size() > 0)
       CheckMockKeyringItem(&mock_keyring_items[0], form_google_, "chrome");
     if (mock_keyring_items.size() > 1)
       CheckMockKeyringItem(&mock_keyring_items[1], form_google_, "chrome-42");
   }
 }