Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(988)

Unified Diff: chrome/browser/ui/views/tab_contents/chrome_web_contents_view_delegate_views.cc

Issue 11647017: Rename platform-independent ConstrainedWindow types to WebContentsModalDialog types (part 1) (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/tab_contents/chrome_web_contents_view_delegate_views.cc
diff --git a/chrome/browser/ui/views/tab_contents/chrome_web_contents_view_delegate_views.cc b/chrome/browser/ui/views/tab_contents/chrome_web_contents_view_delegate_views.cc
index 772fc896f9572a5eaeaac43995b16bb6d3219a1b..1504e4b57b8731d25cbe716644b70247d36f9be9 100644
--- a/chrome/browser/ui/views/tab_contents/chrome_web_contents_view_delegate_views.cc
+++ b/chrome/browser/ui/views/tab_contents/chrome_web_contents_view_delegate_views.cc
@@ -5,11 +5,11 @@
#include "chrome/browser/ui/views/tab_contents/chrome_web_contents_view_delegate_views.h"
#include "chrome/browser/browser_shutdown.h"
-#include "chrome/browser/ui/constrained_window_tab_helper.h"
#include "chrome/browser/ui/sad_tab_helper.h"
#include "chrome/browser/ui/tab_contents/chrome_web_contents_view_delegate.h"
#include "chrome/browser/ui/views/constrained_window_views.h"
#include "chrome/browser/ui/views/tab_contents/render_view_context_menu_views.h"
+#include "chrome/browser/ui/web_contents_modal_dialog_manager.h"
#include "chrome/common/chrome_switches.h"
#include "content/public/browser/render_process_host.h"
#include "content/public/browser/render_view_host.h"
@@ -68,17 +68,17 @@ bool ChromeWebContentsViewDelegateViews::Focus() {
}
}
- ConstrainedWindowTabHelper* constrained_window_tab_helper =
- ConstrainedWindowTabHelper::FromWebContents(web_contents_);
- if (constrained_window_tab_helper) {
- // TODO(erg): WebContents used to own constrained windows, which is why
- // this is here. Eventually this should be ported to a containing view
- // specializing in constrained window management.
- if (constrained_window_tab_helper->constrained_window_count() > 0) {
- ConstrainedWindow* window =
- *constrained_window_tab_helper->constrained_window_begin();
+ WebContentsModalDialogManager* web_contents_modal_dialog_manager =
+ WebContentsModalDialogManager::FromWebContents(web_contents_);
+ if (web_contents_modal_dialog_manager) {
+ // TODO(erg): WebContents used to own web contents modal dialogs, which is
+ // why this is here. Eventually this should be ported to a containing view
+ // specializing in web contents modal dialog management.
+ if (web_contents_modal_dialog_manager->dialog_count() > 0) {
+ WebContentsModalDialog* window =
+ *web_contents_modal_dialog_manager->dialog_begin();
DCHECK(window);
- window->FocusConstrainedWindow();
+ window->FocusWebContentsModalDialog();
return true;
}
}

Powered by Google App Engine
This is Rietveld 408576698