Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2198)

Unified Diff: chrome/browser/ui/gtk/constrained_window_gtk.cc

Issue 11647017: Rename platform-independent ConstrainedWindow types to WebContentsModalDialog types (part 1) (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/gtk/constrained_window_gtk.cc
diff --git a/chrome/browser/ui/gtk/constrained_window_gtk.cc b/chrome/browser/ui/gtk/constrained_window_gtk.cc
index 75e79acd0fe44e4a41f103d368c19fda8b698fe6..8e7200ec227dcbe66d7001349fee38162e95d9bb 100644
--- a/chrome/browser/ui/gtk/constrained_window_gtk.cc
+++ b/chrome/browser/ui/gtk/constrained_window_gtk.cc
@@ -9,10 +9,10 @@
#include "base/bind.h"
#include "base/message_loop.h"
#include "chrome/browser/ui/browser_list.h"
-#include "chrome/browser/ui/constrained_window_tab_helper.h"
-#include "chrome/browser/ui/constrained_window_tab_helper_delegate.h"
#include "chrome/browser/ui/gtk/gtk_util.h"
#include "chrome/browser/ui/gtk/tab_contents/chrome_web_contents_view_delegate_gtk.h"
+#include "chrome/browser/ui/web_contents_modal_dialog_manager.h"
+#include "chrome/browser/ui/web_contents_modal_dialog_manager_delegate.h"
#include "content/public/browser/browser_thread.h"
#include "content/public/browser/web_contents.h"
#include "ui/base/gtk/focus_store_gtk.h"
@@ -73,16 +73,16 @@ ConstrainedWindowGtk::ConstrainedWindowGtk(
g_signal_connect(widget(), "hierarchy-changed",
G_CALLBACK(OnHierarchyChangedThunk), this);
- ConstrainedWindowTabHelper* constrained_window_tab_helper =
- ConstrainedWindowTabHelper::FromWebContents(web_contents_);
- constrained_window_tab_helper->AddConstrainedDialog(this);
+ WebContentsModalDialogManager* web_contents_modal_dialog_manager =
+ WebContentsModalDialogManager::FromWebContents(web_contents_);
+ web_contents_modal_dialog_manager->AddDialog(this);
}
ConstrainedWindowGtk::~ConstrainedWindowGtk() {
border_.Destroy();
}
-void ConstrainedWindowGtk::ShowConstrainedWindow() {
+void ConstrainedWindowGtk::ShowWebContentsModalDialog() {
gtk_widget_show_all(border_.get());
// We collaborate with WebContentsView and stick ourselves in the
@@ -92,28 +92,28 @@ void ConstrainedWindowGtk::ShowConstrainedWindow() {
visible_ = true;
}
-void ConstrainedWindowGtk::CloseConstrainedWindow() {
+void ConstrainedWindowGtk::CloseWebContentsModalDialog() {
if (visible_)
ContainingView()->RemoveConstrainedWindow(this);
delegate_->DeleteDelegate();
- ConstrainedWindowTabHelper* constrained_window_tab_helper =
- ConstrainedWindowTabHelper::FromWebContents(web_contents_);
- constrained_window_tab_helper->WillClose(this);
+ WebContentsModalDialogManager* web_contents_modal_dialog_manager =
+ WebContentsModalDialogManager::FromWebContents(web_contents_);
+ web_contents_modal_dialog_manager->WillClose(this);
delete this;
}
-void ConstrainedWindowGtk::FocusConstrainedWindow() {
+void ConstrainedWindowGtk::FocusWebContentsModalDialog() {
GtkWidget* focus_widget = delegate_->GetFocusWidget();
if (!focus_widget)
return;
// The user may have focused another tab. In this case do not grab focus
// until this tab is refocused.
- ConstrainedWindowTabHelper* helper =
- ConstrainedWindowTabHelper::FromWebContents(web_contents_);
- if ((!helper->delegate() ||
- helper->delegate()->ShouldFocusConstrainedWindow()) &&
+ WebContentsModalDialogManager* manager =
+ WebContentsModalDialogManager::FromWebContents(web_contents_);
+ if ((!manager->delegate() ||
+ manager->delegate()->ShouldFocusWebContentsModalDialog()) &&
gtk_util::IsWidgetAncestryVisible(focus_widget)) {
gtk_widget_grab_focus(focus_widget);
} else {
@@ -142,7 +142,7 @@ gboolean ConstrainedWindowGtk::OnKeyPress(GtkWidget* sender,
// on widget().
MessageLoop::current()->PostTask(
FROM_HERE,
- base::Bind(&ConstrainedWindowGtk::CloseConstrainedWindow,
+ base::Bind(&ConstrainedWindowGtk::CloseWebContentsModalDialog,
weak_factory_.GetWeakPtr()));
return TRUE;
}
@@ -156,5 +156,5 @@ void ConstrainedWindowGtk::OnHierarchyChanged(GtkWidget* sender,
if (!gtk_widget_is_toplevel(gtk_widget_get_toplevel(widget())))
return;
- FocusConstrainedWindow();
+ FocusWebContentsModalDialog();
}

Powered by Google App Engine
This is Rietveld 408576698