Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(320)

Issue 11647012: Improve validation when creating audio streams. (Closed)

Created:
8 years ago by Chris Evans
Modified:
8 years ago
Reviewers:
DaleCurtis
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, feature-media-reviews_chromium.org
Visibility:
Public.

Description

Improve validation when creating audio streams. BUG=166795 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=173981

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -13 lines) Patch
M content/browser/renderer_host/media/audio_input_renderer_host.cc View 2 chunks +5 lines, -2 lines 0 comments Download
M content/browser/renderer_host/media/audio_renderer_host.cc View 1 chunk +7 lines, -11 lines 0 comments Download
M content/common/media/audio_param_traits.cc View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Chris Evans
8 years ago (2012-12-19 02:20:07 UTC) #1
DaleCurtis
lgtm. Nice catch!
8 years ago (2012-12-19 02:39:59 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/cevans@chromium.org/11647012/1
8 years ago (2012-12-19 18:43:42 UTC) #3
commit-bot: I haz the power
8 years ago (2012-12-19 19:44:20 UTC) #4
Retried try job too often on win_rel for step(s) nacl_integration

Powered by Google App Engine
This is Rietveld 408576698