tools/grokdump.py - Issue 1164693002: Tiny fix to grokdump heap stats printer

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/grokdump.py

Issue 1164693002: Tiny fix to grokdump heap stats printer (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/grokdump.py

diff --git a/tools/grokdump.py b/tools/grokdump.py

index 11f8d239f3d4e5a27a9ca15d133b70977e9cfb6d..d2d7092705469f5018c0c9c3d7a018726e548790 100755

--- a/tools/grokdump.py

+++ b/tools/grokdump.py

@@ -3142,7 +3142,7 @@ def AnalyzeMinidump(options, minidump_name):

oom_comment = " <----- HeapStats start marker"

elif maybe_address_contents == 0xdecade01:

oom_comment = " <----- HeapStats end marker"

- else:

+ elif maybe_address_contents is not None:

oom_comment = " %d (%d Mbytes)" % (maybe_address_contents,

maybe_address_contents >> 20)

if slot == frame_pointer:

« no previous file with comments | « no previous file | no next file » | no next file with comments »