Issue 1164683005: win: fix uncaught multiprocess child test failures

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1164683005: win: fix uncaught multiprocess child test failures (Closed)

Created:
5 years, 6 months ago by scottmg

Modified:
5 years, 6 months ago

Reviewers:
erikwright (departed)

CC:
crashpad-dev_chromium.org

Base URL:
https://chromium.googlesource.com/crashpad/crashpad@master

Target Ref:
refs/heads/master

Project:
crashpad

Visibility:
Public.

More Reviews

Description

win: fix uncaught multiprocess child test failures R=erikwright@chromium.org Committed: https://chromium.googlesource.com/crashpad/crashpad/+/1d33a8b0b62ca6c08726430a354370c2b9ba548a

Patch Set 2 : 0 -> EXIT_SUCCESS #

Created: 5 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+48 lines, -1 line)			Patch
	M	test/win/win_multiprocess.cc	View	1	1 chunk	+4 lines, -1 line	0 comments	Download
	M	test/win/win_multiprocess_test.cc	View		2 chunks	+44 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

erikwright (departed)

LGTM https://codereview.chromium.org/1164683005/diff/1/test/win/win_multiprocess.cc File test/win/win_multiprocess.cc (right): https://codereview.chromium.org/1164683005/diff/1/test/win/win_multiprocess.cc#newcode106 test/win/win_multiprocess.cc:106: exit(0); Should 0 be EXIT_SUCCESS, for consistency with ...

5 years, 6 months ago (2015-06-01 18:54:08 UTC) #2

scottmg

https://codereview.chromium.org/1164683005/diff/1/test/win/win_multiprocess.cc File test/win/win_multiprocess.cc (right): https://codereview.chromium.org/1164683005/diff/1/test/win/win_multiprocess.cc#newcode106 test/win/win_multiprocess.cc:106: exit(0); On 2015/06/01 18:54:08, erikwright wrote: > Should 0 ...

5 years, 6 months ago (2015-06-01 19:17:04 UTC) #3

scottmg

5 years, 6 months ago (2015-06-01 19:17:16 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
1d33a8b0b62ca6c08726430a354370c2b9ba548a (presubmit successful).

Expand Messages | Collapse Messages

Issue 1164683005: win: fix uncaught multiprocess child test failures (Closed)

Description

Patch Set 1 #

Patch Set 2 : 0 -> EXIT_SUCCESS #

Messages