Oilpan: Add ENABLE_LAZY_SWEEPING and ENABLE_IDLE_GC to features.gypi

Oilpan: Add ENABLE_LAZY_SWEEPING and ENABLE_IDLE_GC to features.gypi

It's not nice to define macros in an actual header file.
We should define it in features.gypi. So this CL moves the definition
of ENABLE_LAZY_SWEEPING to features.gypi. This CL also defines
ENABLE_IDLE_GC for ease of our experiments.

This CL doesn't change any behavior.

BUG=420515
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=196362

[haraken, 2015-06-02 08:49:32]

haraken@chromium.org changed reviewers:
+ oilpan-reviews@chromium.org, peria@chromium.org, yutak@chromium.org

[haraken, 2015-06-02 08:49:33]

PTAL

[peria, 2015-06-02 09:03:24]

https://codereview.chromium.org/1164643005/diff/1/Source/build/features.gypi
File Source/build/features.gypi (right):

https://codereview.chromium.org/1164643005/diff/1/Source/build/features.gypi#...
Source/build/features.gypi:94: 'feature_defines': [
Please do either one of following items.
1. Leave TODO comments that are removed in some .h files here.
2. Remove this "else" part.  We can assume ENABLE(FOO) is false by default.

[haraken, 2015-06-02 09:05:51]

On 2015/06/02 09:03:24, peria wrote:
> https://codereview.chromium.org/1164643005/diff/1/Source/build/features.gypi
> File Source/build/features.gypi (right):
> 
>
https://codereview.chromium.org/1164643005/diff/1/Source/build/features.gypi#...
> Source/build/features.gypi:94: 'feature_defines': [
> Please do either one of following items.
> 1. Leave TODO comments that are removed in some .h files here.
> 2. Remove this "else" part.  We can assume ENABLE(FOO) is false by default.

Did 2. (That was for your ease to enable those flags :-)

[peria, 2015-06-02 09:11:32]

I'm sorry, I forgot to mention about more important point.
We have to add more branches for our experiments.

https://codereview.chromium.org/1164643005/diff/20001/Source/build/features.gypi
File Source/build/features.gypi (right):

https://codereview.chromium.org/1164643005/diff/20001/Source/build/features.g...
Source/build/features.gypi:93: }],
We need
['enable_lazy_sweeping=1', {'feature_defines': ['ENABLE_LAZY_SWEEPING=1']}],
['enable_idle_gc=1', {'feature_defines': ['ENABLE_IDLE_GC=1']}]
to enable to change behaviors by GYP_DEFINES.

[haraken, 2015-06-02 09:19:42]

https://codereview.chromium.org/1164643005/diff/20001/Source/build/features.gypi
File Source/build/features.gypi (right):

https://codereview.chromium.org/1164643005/diff/20001/Source/build/features.g...
Source/build/features.gypi:93: }],
On 2015/06/02 09:11:32, peria wrote:
> We need
> ['enable_lazy_sweeping=1', {'feature_defines': ['ENABLE_LAZY_SWEEPING=1']}],
> ['enable_idle_gc=1', {'feature_defines': ['ENABLE_IDLE_GC=1']}]
> to enable to change behaviors by GYP_DEFINES.

I'm not sure if we need to expose those flags to GYP. These flags are very
temporary ones, so yutakp and I were expecting that you edit features.gypi
locally.

[peria, 2015-06-02 09:20:35]

On 2015/06/02 09:19:42, haraken wrote:
>
https://codereview.chromium.org/1164643005/diff/20001/Source/build/features.gypi
> File Source/build/features.gypi (right):
> 
>
https://codereview.chromium.org/1164643005/diff/20001/Source/build/features.g...
> Source/build/features.gypi:93: }],
> On 2015/06/02 09:11:32, peria wrote:
> > We need
> > ['enable_lazy_sweeping=1', {'feature_defines': ['ENABLE_LAZY_SWEEPING=1']}],
> > ['enable_idle_gc=1', {'feature_defines': ['ENABLE_IDLE_GC=1']}]
> > to enable to change behaviors by GYP_DEFINES.
> 
> I'm not sure if we need to expose those flags to GYP. These flags are very
> temporary ones, so yutakp and I were expecting that you edit features.gypi
> locally.

Ah, got it.
Thanks.

[peria, 2015-06-02 09:20:42]

lgtm

[haraken, 2015-06-02 09:21:40]

haraken@chromium.org changed reviewers:
+ tkent@chromium.org

[haraken, 2015-06-02 09:21:41]

tkent-san: Mind taking a look at wtf/?

[tkent, 2015-06-02 22:30:01]

lgtm

[haraken, 2015-06-02 23:18:33]

The CQ bit was checked by haraken@chromium.org

[commit-bot: I haz the power, 2015-06-02 23:19:32]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1164643005/20001

[commit-bot: I haz the power, 2015-06-03 02:13:30]

Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=196362