Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(157)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1164633004: Adds support for transfer mode in Paint and SpriteNode classes (Closed)

Created:
5 years, 6 months ago by viktorl
Modified:
5 years, 6 months ago
Reviewers:
Matt Perry, eseidel
CC:
abarth-chromium, gregsimon, mojo-reviews_chromium.org, qsr+mojo_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Adds support for transfer mode in Paint and SpriteNode classes. Adds support for opacity in sprites, and modifies example game. R=eseidel@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/2230311e1c78da2d3eebe627840e8c8ec8dd44b7

Patch Set 1 #

Total comments: 4

Patch Set 2 : Fixes indentations and whitespaces #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -2 lines) Patch
M sky/engine/core/painting/Paint.h View 2 chunks +3 lines, -0 lines 0 comments Download
M sky/engine/core/painting/Paint.cpp View 1 1 chunk +5 lines, -0 lines 0 comments Download
M sky/engine/core/painting/Paint.idl View 1 chunk +1 line, -0 lines 0 comments Download
M sky/examples/game/lib/game_world.dart View 1 chunk +2 lines, -0 lines 0 comments Download
M sky/examples/game/lib/sprite_node.dart View 1 3 chunks +23 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
viktorl
5 years, 6 months ago (2015-06-04 17:43:58 UTC) #2
eseidel
5 years, 6 months ago (2015-06-04 17:46:55 UTC) #4
eseidel
lgtm https://codereview.chromium.org/1164633004/diff/1/sky/engine/core/painting/Paint.h File sky/engine/core/painting/Paint.h (right): https://codereview.chromium.org/1164633004/diff/1/sky/engine/core/painting/Paint.h#newcode47 sky/engine/core/painting/Paint.h:47: void setTransferMode(SkXfermode::Mode transfer_mode); I believe this file is ...
5 years, 6 months ago (2015-06-04 17:49:50 UTC) #5
Matt Perry
https://codereview.chromium.org/1164633004/diff/1/sky/engine/core/painting/Paint.cpp File sky/engine/core/painting/Paint.cpp (right): https://codereview.chromium.org/1164633004/diff/1/sky/engine/core/painting/Paint.cpp#newcode42 sky/engine/core/painting/Paint.cpp:42: m_paint.setXfermodeMode(transfer_mode); indent https://codereview.chromium.org/1164633004/diff/1/sky/examples/game/lib/sprite_node.dart File sky/examples/game/lib/sprite_node.dart (right): https://codereview.chromium.org/1164633004/diff/1/sky/examples/game/lib/sprite_node.dart#newcode25 sky/examples/game/lib/sprite_node.dart:25: assert(opacity ...
5 years, 6 months ago (2015-06-04 17:50:18 UTC) #6
viktorl
5 years, 6 months ago (2015-06-04 18:14:13 UTC) #7
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
2230311e1c78da2d3eebe627840e8c8ec8dd44b7 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698